unreachable code entered when SELECTing nested composite types and DOMAINs
#1188
Comments
zacknewman
changed the title
unreachable code entered when using nested composite types and DOMAINsunreachable code entered when SELECTing nested composite types and DOMAINs
|
Some extra information. The
|
|
OK, I looked at the code that is generated; and I believe I found the issue. Generated code: #[postgres(name = "bar")]
struct Bar(Foo);
impl<'a> postgres_types::FromSql<'a> for Bar {
fn from_sql(_type: &postgres_types::Type, buf: &'a [u8])
->
std::result::Result<Bar,
std::boxed::Box<dyn std::error::Error + std::marker::Sync +
std::marker::Send>> {
<Foo as postgres_types::FromSql>::from_sql(_type, buf).map(Bar)
}
fn accepts(type_: &postgres_types::Type) -> bool {
if <Foo as postgres_types::FromSql>::accepts(type_) { return true; }
if type_.name() != "bar" { return false; }
match *type_.kind() {
::postgres_types::Kind::Domain(ref type_) => {
<Foo as ::postgres_types::ToSql>::accepts(type_)
}
_ => false,
}
}
}
fn from_sql(_type: &postgres_types::Type, buf: &'a [u8])
->
std::result::Result<Bar,
std::boxed::Box<dyn std::error::Error + std::marker::Sync +
std::marker::Send>> {
match *_type.kind() {
postgres_types::Kind::Domain(ref type_) => {
<Foo as postgres_types::FromSql>::from_sql(type_, buf).map(Bar)
}
ref bad => unreachable!("Bar::from_sql was passed a type whose kind was {bad:?}, but it must be passed a type whose kind is Kind::Domain"),
}
}When I make that fix, the code works; however it now breaks when It makes me suspicious how |
|
I remember there being some funkiness around domains where postgres uses the underlying type directly in some cases instead of the domain type. The logic might just need to handle both cases? |
|
Hm, I'd be interested to see such an example. While I realize most people should just |
|
OK, I submitted a fix that allows |
Execute the following transaction on a PostgreSQL database:
Now compile and run the following Rust program:
Additional information:
The text was updated successfully, but these errors were encountered: