diff --git a/.all-contributorsrc b/.all-contributorsrc index a8e5888..da9d122 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -447,6 +447,15 @@ "infra", "review" ] + }, + { + "login": "VivekFitkariwala", + "name": "Vivek Fitkariwala", + "avatar_url": "https://avatars2.githubusercontent.com/u/3822890?v=4", + "profile": "https://github.com/VivekFitkariwala", + "contributions": [ + "code" + ] } ], "repoType": "github" diff --git a/README.md b/README.md index aeb53e9..5f9098f 100644 --- a/README.md +++ b/README.md @@ -13,7 +13,7 @@ All the benefits of npm scripts without the cost of a bloated package.json and l [![downloads][downloads-badge]][npm-stat] [![MIT License][license-badge]][license] -[![All Contributors](https://img.shields.io/badge/all_contributors-43-orange.svg?style=flat-square)](#contributors) +[![All Contributors](https://img.shields.io/badge/all_contributors-45-orange.svg?style=flat-square)](#contributors) [![PRs Welcome][prs-badge]][prs] [![Donate][donate-badge]][donate] [![Code of Conduct][coc-badge]][coc] @@ -519,7 +519,7 @@ Thanks goes to these people ([emoji key][emojis]): | [
Erik Fox](http://www.erikfox.co/)
[πŸ›](https://github.com/kentcdodds/p-s/issues?q=author%3Aerikfox "Bug reports") [πŸ’»](https://github.com/kentcdodds/p-s/commits?author=erikfox "Code") [πŸ“–](https://github.com/kentcdodds/p-s/commits?author=erikfox "Documentation") [⚠️](https://github.com/kentcdodds/p-s/commits?author=erikfox "Tests") | [
Aditya Pratap Singh](http://blog.adityapsingh.com)
[πŸ‘€](#review-addityasingh "Reviewed Pull Requests") | [
bumbleblym](https://github.com/bumbleblym)
[πŸ’»](https://github.com/kentcdodds/p-s/commits?author=bumbleblym "Code") [πŸ“–](https://github.com/kentcdodds/p-s/commits?author=bumbleblym "Documentation") | [
Islam Attrash](https://twitter.com/IslamAttrash)
[πŸ’»](https://github.com/kentcdodds/p-s/commits?author=Attrash-Islam "Code") | [
JasonSooter](https://github.com/JasonSooter)
[πŸ“–](https://github.com/kentcdodds/p-s/commits?author=JasonSooter "Documentation") | [
Nate Cavanaugh](http://alterform.com)
[πŸ’»](https://github.com/kentcdodds/p-s/commits?author=natecavanaugh "Code") | [
Wissam Abirached](https://designingforscale.com)
[πŸ’»](https://github.com/kentcdodds/p-s/commits?author=wabirached "Code") [⚠️](https://github.com/kentcdodds/p-s/commits?author=wabirached "Tests") | | [
PaweΕ‚ MikoΕ‚ajczyk](https://github.com/Miklet)
[πŸ’»](https://github.com/kentcdodds/p-s/commits?author=Miklet "Code") [⚠️](https://github.com/kentcdodds/p-s/commits?author=Miklet "Tests") | [
Kyle Welch](http://www.krwelch.com)
[πŸ’»](https://github.com/kentcdodds/p-s/commits?author=kwelch "Code") [⚠️](https://github.com/kentcdodds/p-s/commits?author=kwelch "Tests") | [
Lufty Wiranda](http://instagram.com/luftywiranda13)
[πŸ’»](https://github.com/kentcdodds/p-s/commits?author=luftywiranda13 "Code") | [
Bhargav Ponnapalli](http://imbhargav5.com)
[πŸ’»](https://github.com/kentcdodds/p-s/commits?author=imbhargav5 "Code") | [
falieson](https://github.com/Falieson)
[πŸ“–](https://github.com/kentcdodds/p-s/commits?author=Falieson "Documentation") [πŸ”§](#tool-Falieson "Tools") | [
Suhas Karanth](https://github.com/sudo-suhas)
[πŸ›](https://github.com/kentcdodds/p-s/issues?q=author%3Asudo-suhas "Bug reports") [πŸ’»](https://github.com/kentcdodds/p-s/commits?author=sudo-suhas "Code") | [
Eric Skram](http://www.ericskram.com)
[πŸ“–](https://github.com/kentcdodds/p-s/commits?author=Vpr99 "Documentation") | | [
Kether Saturnius](http://www.k3th3r.com)
[πŸ’»](https://github.com/kentcdodds/p-s/commits?author=iamkether "Code") [πŸ“–](https://github.com/kentcdodds/p-s/commits?author=iamkether "Documentation") | [
Sviatoslav](https://github.com/SleepWalker)
[πŸ›](https://github.com/kentcdodds/p-s/issues?q=author%3ASleepWalker "Bug reports") [πŸ’»](https://github.com/kentcdodds/p-s/commits?author=SleepWalker "Code") | [
Wei Wang](https://github.com/onlywei)
[πŸ’»](https://github.com/kentcdodds/p-s/commits?author=onlywei "Code") | [
Sami Jaber](http://twitter.com/samjabz)
[πŸ›](https://github.com/kentcdodds/p-s/issues?q=author%3Asamijaber "Bug reports") [πŸ’»](https://github.com/kentcdodds/p-s/commits?author=samijaber "Code") | [
Florian LΓΆchle](https://github.com/schottilol)
[πŸ’»](https://github.com/kentcdodds/p-s/commits?author=schottilol "Code") | [
Kevin J](https://github.com/kevjin)
[πŸ’»](https://github.com/kentcdodds/p-s/commits?author=kevjin "Code") | [
Ben Teichman](http://www.benteichman.ca)
[πŸ’»](https://github.com/kentcdodds/p-s/commits?author=effervescentia "Code") [πŸ“–](https://github.com/kentcdodds/p-s/commits?author=effervescentia "Documentation") | -| [
Alex Hansen](http://alex-hansen.com)
[πŸ’»](https://github.com/kentcdodds/p-s/commits?author=sezna "Code") [πŸš‡](#infra-sezna "Infrastructure (Hosting, Build-Tools, etc)") [πŸ‘€](#review-sezna "Reviewed Pull Requests") | +| [
Alex Hansen](http://alex-hansen.com)
[πŸ’»](https://github.com/kentcdodds/p-s/commits?author=sezna "Code") [πŸš‡](#infra-sezna "Infrastructure (Hosting, Build-Tools, etc)") [πŸ‘€](#review-sezna "Reviewed Pull Requests") | [
Casey Primozic](https://cprimozic.com)
[πŸš‡](#infra-ameobea "Infrastructure (Hosting, Build-Tools, etc)") [πŸ‘€](#review-ameobea "Reviewed Pull Requests") | [
Vivek Fitkariwala](https://github.com/VivekFitkariwala)
[πŸ’»](https://github.com/kentcdodds/p-s/commits?author=VivekFitkariwala "Code") | This project follows the [all-contributors][all-contributors] specification. diff --git a/package.json b/package.json index fe7020b..decfc1f 100644 --- a/package.json +++ b/package.json @@ -30,7 +30,7 @@ "readline-sync": "^1.4.7", "spawn-command-with-kill": "^1.0.0", "type-detect": "^4.0.3", - "yargs": "^8.0.2" + "yargs": "14.2.0" }, "devDependencies": { "all-contributors-cli": "^4.3.0", @@ -63,7 +63,8 @@ ], "rules": { "max-len": "off", - "max-lines": "off" + "max-lines": "off", + "no-useless-escape": "off" } }, "lint-staged": { diff --git a/src/bin-utils/__tests__/parser.js b/src/bin-utils/__tests__/parser.js index a932538..c85c818 100644 --- a/src/bin-utils/__tests__/parser.js +++ b/src/bin-utils/__tests__/parser.js @@ -128,7 +128,7 @@ test('happy path', () => { const {argv, psConfig} = parse('"build --fast"') expect(mockBinUtils.loadConfig).toHaveBeenCalledTimes(1) expect(psConfig.isMock).toBe(true) - expect(argv).toMatchObject({_: ['build --fast']}) + expect(argv).toEqual(expect.objectContaining({_: [`\"build --fast\"`]})) }) test('with CLI config', () => { @@ -141,11 +141,13 @@ test('with CLI config', () => { expect(mockBinUtils.loadConfig).toHaveBeenCalledTimes(1) expect(mockBinUtils.loadCLIConfig).toHaveBeenCalledTimes(1) expect(psConfig.isMock).toBe(true) - expect(argv).toMatchObject({ - _: ['build --fast'], - require: 'ts-node/register', - config: 'package-scripts.ts', - }) + expect(argv).toEqual( + expect.objectContaining({ + _: [`\"build --fast\"`], + require: 'ts-node/register', + config: 'package-scripts.ts', + }), + ) delete mockFindUp.mock.cliReturn delete mockBinUtils.mock.cliConfig