Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GStreamerWebRtcDataChannel::new panics in various cases #360

Open
jdm opened this issue Jun 20, 2020 · 1 comment
Open

GStreamerWebRtcDataChannel::new panics in various cases #360

jdm opened this issue Jun 20, 2020 · 1 comment
Assignees
Labels

Comments

@jdm
Copy link
Member

jdm commented Jun 20, 2020

The expect in GStreamerWebRtcDataChannel::new causes panics if:

  • the associated webrtc element is closed
  • both DataChannelInit::max_packet_lifetime and DatachannelInit::max_retransmits are present
  • DataChannelInit::negotiated is true and DataChannelInit::id is not present
  • DataChannelInit::id is present and isn't valid
@jdm jdm added the webrtc label Jun 20, 2020
@ferjm ferjm self-assigned this Jun 22, 2020
@jdm
Copy link
Member Author

jdm commented Apr 20, 2021

Another example of a panic, stemming from a gstreamer that isn't prepared to create webrtcbin elements: servo/servo#28357

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants