fix playground/graphiql on lambda #306
Conversation
|
awesome! thanks @lookapanda . Although I am not sure if we need these changes in rest and dynamodb backend because they are working. The only problem we see is with RDS (maybe based on long lasting connections). Any reason we need to make these changes in dynamo/rest as well? |
app-backend/dynamodb/handler.js
Outdated
| ? process.env.REACT_APP_GRAPHQL_ENDPOINT | ||
| : '/production/graphql', | ||
| }); | ||
| exports.playgroundHandler = (event, context, callback) => { |
There was a problem hiding this comment.
I mean I don't think we need these changes in rest and dynamodb backend. GraphiQL and Playground are working with those backends. We only see problem with RDS
app-backend/rest-api/handler.js
Outdated
| ? process.env.REACT_APP_GRAPHQL_ENDPOINT | ||
| : '/production/graphql', | ||
| }); | ||
| exports.playgroundHandler = (event, context, callback) => { |
|
I just assumed it isn't working for the others aswell, I was using RDS when I noticed it isn't working. For testing I had to use my private AWS account and I don't have a running RDS instance, sorry :P |
|
Fair enough :)
|
|
I didn't test this particular PR for RDS, but as I said, on our project, we're using it with RDS and I had to do this change to make it work. It was already running locally, it's only an issue on the actual Lambda. |
|
correct! ok sounds good :) Lets merge this PR once you revert back changes for dynamo and rest. |
Apparently, it's only needed for RDS (serverless#306 (comment))
As suggested: #256 (comment)
Tested and works: https://7z9jwa60yg.execute-api.us-east-1.amazonaws.com/production/playground