Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement 'seriesP . seriesF @AnyList ≡ id' testing property #64

Open
1 of 2 tasks
chshersh opened this issue Jan 22, 2018 · 2 comments
Open
1 of 2 tasks

Implement 'seriesP . seriesF @AnyList ≡ id' testing property #64

chshersh opened this issue Jan 22, 2018 · 2 comments
Labels
tests type-level-magic

Comments

@chshersh
Copy link
Contributor

chshersh commented Jan 22, 2018 •
edited by vrom911
Loading

After #60 and #63 is done we can implement such property. Though it's really difficult to implement this as it seems to me...

  1. We need to somehow generate random type-level list of time units.
  2. We need to think of a way to make seriesF result actually meaningful. We don't want to generate 1234 picoseconds and format this with lists [Hour, Minute, Second] very often.
  • unitsF and unitsP
  • Think how to generate random list of types
@chshersh chshersh added this to the v0.1.0 milestone Feb 6, 2018
@chshersh chshersh mentioned this issue Feb 6, 2018
Closed
@chshersh
Copy link
Contributor Author

I think for now we can just have tests with unitsF and unitsP and only much later think on more sophisticated tests.

@vrom911 vrom911 self-assigned this Feb 11, 2018
vrom911 added a commit that referenced this issue Feb 11, 2018
@vrom911
[#64] Add property tests for unitsP . unitsF = id
d404f77
@vrom911 vrom911 mentioned this issue Feb 11, 2018
Merged
chshersh added a commit that referenced this issue Feb 11, 2018
@chshersh
Merge pull request #88 from serokell/vrom911/64-series-test
0b81d73 
[#64] Add property tests for unitsP . unitsF = id
@chshersh
Copy link
Contributor Author

For generating random type level lists we could use trick suggested in this tweet:

@chshersh chshersh removed this from the v0.1.0 milestone Feb 26, 2018
@vrom911 vrom911 removed their assignment Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests type-level-magic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chshersh @vrom911