From 31f08f2d34624950f5397971b1b7b1421d559304 Mon Sep 17 00:00:00 2001
From: Peter-MJ-Parker <34216187+Peter-MJ-Parker@users.noreply.github.com>
Date: Fri, 23 Feb 2024 08:15:23 -0600
Subject: [PATCH] chore: update disable.ts

Noticed a few bugs.
1) Changed invalid import from discord.js. Implicitly had an any type for `onFail`.
```diff
-ReplyMessageOptions
+MessageReplyOptions
```
2) Corrected the improper catching of errors by implementing try/catch blocks. Included more detailed error responses.
3) Default reply for slash with onFail inputted was invalid because it could also be a string.
---
 plugins/disable.ts | 49 +++++++++++++++++++++++++++++-----------------
 1 file changed, 31 insertions(+), 18 deletions(-)

diff --git a/plugins/disable.ts b/plugins/disable.ts
index 2f61515..4267426 100644
--- a/plugins/disable.ts
+++ b/plugins/disable.ts
@@ -1,11 +1,11 @@
-// @ts-nocheck
+//@ts-nocheck
 /**
  * @plugin
  * Disables a command entirely, for whatever reasons you may need.
  *
  * @author @jacoobes [<@182326315813306368>]
  * @author @Peter-MJ-Parker [<@371759410009341952>]
- * @version 2.0.0
+ * @version 2.1.0
  * @example
  * ```ts
  * import { disable } from "../plugins/disable";
@@ -20,36 +20,49 @@
  * @end
  */
 import { CommandType, CommandControlPlugin, controller } from "@sern/handler";
-import { InteractionReplyOptions, ReplyMessageOptions } from "discord.js";
+import { InteractionReplyOptions, MessageReplyOptions } from "discord.js";
 
 export function disable(
 	onFail?:
 		| string
 		| Omit<InteractionReplyOptions, "fetchReply">
-		| ReplyMessageOptions,
+		| MessageReplyOptions
 ) {
 	return CommandControlPlugin<CommandType.Both>(async (ctx, [args]) => {
 		if (onFail !== undefined) {
 			switch (args) {
 				case "text":
-					//reply to text command
-					const msg = await ctx.reply(onFail);
-					setTimeout(() => {
-						//deletes the bots reply to the user
-						msg.delete();
-						//deletes the original authors message (text command).
-						ctx.message.delete();
-						//waits 5 seconds before deleting messages
-					}, 5000).catch((e) => {
-						//logs error to console (if any).
-						console.log(e);
-					});
+					try {
+						//reply to text command
+						const msg = await ctx.reply(onFail);
+						setTimeout(() => {
+							//deletes the bots reply to the user
+							msg.delete();
+							//deletes the original authors message (text command).
+							ctx.message.delete();
+							//waits 5 seconds before deleting messages
+						}, 5000);
+					} catch (error) {
+						console.log(
+							"Could not delete disabled response due to: " +
+								error
+						);
+					}
 
 					break;
 
 				case "slash":
-					//ephemeral response to say the command is disabled with users response.
-					await ctx.reply({ content: onFail, ephemeral: true });
+					//response to say the command is disabled with users response.
+					let reply = await ctx.reply(onFail);
+					try {
+						setTimeout(async () => {
+							await reply.delete();
+						}, 5000);
+					} catch (error) {
+						console.log(
+							"Could not delete disabled response due to it being ephemeral."
+						);
+					}
 					break;
 
 				default: