Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Xds flow control service #1693

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

hanbingleixue
Copy link
Collaborator

@hanbingleixue hanbingleixue commented Dec 3, 2024

What type of PR is this?

Feature

What this PR does / why we need it?

Add Xds flow control service

Which issue(s) this PR fixes?

Fixes #1515

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 36.90476% with 159 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ment/service/xds/utils/RdsProtocolTransformer.java 10.52% 100 Missing and 2 partials ⚠️
...ice/xds/flowcontrol/XdsFlowControlServiceImpl.java 33.33% 16 Missing and 10 partials ⚠️
.../implement/service/xds/entity/DenominatorType.java 0.00% 13 Missing ⚠️
...ant/core/service/xds/entity/XdsServiceCluster.java 33.33% 4 Missing and 4 partials ⚠️
...mant/implement/service/xds/XdsCoreServiceImpl.java 0.00% 5 Missing ⚠️
...ment/service/xds/utils/CdsProtocolTransformer.java 92.59% 1 Missing and 1 partial ⚠️
...service/xds/entity/XdsInstanceCircuitBreakers.java 75.00% 1 Missing ⚠️
...ermant/core/service/xds/entity/XdsRouteAction.java 66.66% 1 Missing ⚠️
...mant/implement/service/xds/handler/XdsHandler.java 90.00% 0 Missing and 1 partial ⚠️
Flag Coverage Δ Complexity Δ
unittests 43.87% <36.90%> (-0.11%) 181.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ Complexity Δ
...in/java/io/sermant/core/common/CommonConstant.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...a/io/sermant/core/service/xds/entity/XdsAbort.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...io/sermant/core/service/xds/entity/XdsCluster.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...a/io/sermant/core/service/xds/entity/XdsDelay.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
.../sermant/core/service/xds/entity/XdsRateLimit.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
.../service/xds/entity/XdsRequestCircuitBreakers.java 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...a/io/sermant/core/service/xds/entity/XdsRoute.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...mant/implement/service/xds/cache/XdsDataCache.java 85.91% <100.00%> (ø) 0.00 <0.00> (ø)
...mant/implement/service/xds/handler/CdsHandler.java 94.28% <100.00%> (ø) 0.00 <0.00> (ø)
...mant/implement/service/xds/handler/EdsHandler.java 86.66% <100.00%> (ø) 0.00 <0.00> (ø)
... and 11 more

... and 1 file with indirect coverage changes

@zwmagic zwmagic self-requested a review December 4, 2024 06:07
@hanbingleixue hanbingleixue force-pushed the flowcontrol branch 5 times, most recently from 919e1db to 96a0ae3 Compare December 6, 2024 07:28
@zwmagic zwmagic self-requested a review December 6, 2024 07:51
zwmagic
zwmagic previously approved these changes Dec 6, 2024
zwmagic
zwmagic previously approved these changes Dec 6, 2024
@hanbingleixue hanbingleixue force-pushed the flowcontrol branch 7 times, most recently from 1a03dda to 52a9306 Compare December 13, 2024 02:53
Signed-off-by: hanbingleixue <[email protected]>
@Sherlockhan Sherlockhan merged commit 214a423 into sermant-io:develop Dec 13, 2024
300 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supports xDS protocol to communicate with the Control Plane of Service Mesh
5 participants