This repository has been archived by the owner on Jul 24, 2018. It is now read-only.
Adds a SLIP encoder #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanSanchez
force-pushed
the
slip-encoder
branch
from
f072657
to
253fcfd
Compare
Codecov Report
@@ Coverage Diff @@
## master #12 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 6 7 +1
Lines 117 146 +29
=====================================
+ Hits 117 146 +29
Continue to review full report at Codecov.
|
IvanSanchez
force-pushed
the
slip-encoder
branch
from
253fcfd
to
8517b38
Compare
|
I'm so sorry I missed this! This is great! |
reconbot
reviewed
May 5, 2018
| @@ -0,0 +1,11 @@ | |||
| { | |||
There was a problem hiding this comment.
don't commit this file, we'll want to make sure the latest safe-buffer gets tested in the CI and it's ignored in libraries
|
Should SLIP be added to the README? |
|
Already there =) published as https://www.npmjs.com/package/@serialport/parser-slip-encoder |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements part of #10