Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for read returning available data before timeout #200

Merged

Conversation

sirhcel
Copy link
Contributor

@sirhcel sirhcel commented Jul 10, 2024

This PR adds an integration test case checking that read returns the data currently available even before the specified read timeout has been reached.

This was not the case on Windows before #79 but there was no test covering this part of the expected behavior. According to the test added here, #196 should be fixed with release 4.4.0 and the behavior described in the issue can be seen when running this test on 0a75184.

@sirhcel sirhcel requested a review from eldruin July 10, 2024 20:28
Copy link
Contributor

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@eldruin eldruin merged commit cbd343c into serialport:main Jul 12, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants