Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nightly #169

Merged
merged 4 commits into from
Apr 4, 2024
Merged

Fix nightly #169

merged 4 commits into from
Apr 4, 2024

Commits on Mar 28, 2024

  1. Fix nightly lint causing compilation to fail

    @RossSmyth @sirhcel
    RossSmyth authored and sirhcel committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    97f8fcc View commit details
    Browse the repository at this point in the history

  2. Relax checks on unused imports 

    This is definitely worth a warning but should not make builds fail for
users. We deny warnings in CI and sort this out before integrating.

See issue serialport#169 for more details.
    @sirhcel
    sirhcel committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    8d94b1a View commit details
    Browse the repository at this point in the history

  3. Don't let nightly builds fail CI

    @sirhcel
    sirhcel committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    6b84960 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. Clean up superfluous explicit import 

    Current nightly considers use nix::self as an unused import as nix is
already through the extern prelude (since edition 2018) and generates a
warning. Remove the explicit import to silence it.

See:

* Output of 'cargo --verbose check'
* https://doc.rust-lang.org/stable/reference/names/preludes.html#extern-prelude
    @sirhcel
    sirhcel committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    7fec3df View commit details
    Browse the repository at this point in the history