Fix write timeout for COM ports #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nskartoredjo
commented
Feb 13, 2024
eldruin
reviewed
Feb 14, 2024
There was a problem hiding this comment.
Great, thank you for finding and fixing this.
Indeed it is already documented that the set_timeout function "Sets the timeout for future I/O operations." so I would classify this as a fix and not a change.
Could you add an entry about this in the Fixed section of the changelog?
I understand this fixes #124
|
Sorry for the long wait, I've updated the changelog while trying to keep the current format |
eldruin
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the issue where the COM-port write procedure is blocking, which is caused by a static timeout deceleration equal to zero. In general, you would suspect that the
set_timeoutbuilder method applies a timeout to both the read and write procedures, as the documentation would suggest.Fixes #124