Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Junit5 support #2

Open
62mkv opened this issue Dec 1, 2020 · 2 comments
Open

Junit5 support #2

62mkv opened this issue Dec 1, 2020 · 2 comments

Comments

@62mkv
Copy link

62mkv commented Dec 1, 2020

Hi! From the README and a quick glance at the code, it looks as this project does not have JUnit 5-compatible data providers? if so, would it make sense to add those? or should it rather be a separate project in this case?

I was just looking for Excel-data provider for JUnit5, and, even though it was rather trivial to implement as a @MethodSource, I still think it's worth being in a library, and this one looks like the best possible candidate.. What do you think? I could contribute the implementation, with some guidance, probably.

@sergueik
Copy link
Owner

sergueik commented Dec 1, 2020

Thanks for asking - originally the junit-dataroviders is relying on junitparam - it was started when the junit 4 was quite stable and widely used and the junit-dataproviders and testng-dataproviders are very much like one another. i may missed the event of junit5 becoming popular to start convertions -will be happy to do the work

@sergueik
Copy link
Owner

sergueik commented Dec 2, 2020

Documented adapting the data provider to a Junit 5 @MethodSource in the README.md. Will convert to junit 5 in a little bit - it does not seem practical to have one pom.xml etc for both releases of framefork, and pom.xml is already overloaded with profiles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants