Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UMD build defined in package.json, but missing in published npm package #203

Open
mcebular opened this issue Feb 11, 2022 · 0 comments
Open

Comments

@mcebular
Copy link

package.json defines

"browser": "dist/sentinelHub.umd.js"

however there is no dist/sentinelHub.umd.js in the final package published to NPM.
Looking at rollup.config.js, it seems that rollup is not configured to build UMD at all.

This can potentially break building processes of users that depend on sentinelhub-js and expect the UMD module to exist in the npm package (based on the information provided in package.json).

What should be done is either:

  • remove browser entry from package.json, or
  • configure rollup to also bundle the UMD.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant