Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server is down again and clients gain seconds to run time without any hint on that #43

Open
yarikoptic opened this issue Dec 14, 2022 · 1 comment

Comments

@yarikoptic
Copy link
Collaborator

noted that dandi client is too slow, thought that it would be some added recent imports. nope:

❯ dandi -l 1 validate
2022-12-14 16:32:28,296 [   DEBUG] Starting new HTTPS connection (1): rig.mit.edu:443
2022-12-14 16:32:33,305 [   DEBUG] Could not check dandi/dandi-cli for version updates: Connection to server could not be made

so it took 5 seconds to silently timeout while checking for updates. I feel like we should add such checks to happen out of band - e.g. that function to start a thread which would be joined/waited at the end of the process (atexit) or smth like that.

@mgxd
Copy link
Collaborator

mgxd commented Dec 14, 2022

It can definitely be optimized, but as a low hanging fruit we could change

kwargs['timeout'] = 5

to use separate timeouts for connect/read, perhaps something like (0.5, 5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants