Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do these labels come up empty? #5

Open
AnadyaNair opened this issue Sep 18, 2023 · 4 comments
Open

Why do these labels come up empty? #5

AnadyaNair opened this issue Sep 18, 2023 · 4 comments
Assignees

Comments

@AnadyaNair
Copy link

image
image
image
image
image
image

@ylg
Copy link
Member

ylg commented Sep 18, 2023

ISS (or perhaps the ground relay) often sends only on change. Eventually, you'll see empty fields populate as upstream changes cause pushes.

That said, we've actually got the historical data in permanent storage. So the app could fetch and "backfill" at startup.

And, we've a fork that already does this, just waiting on some tweaks from me. I'll see if I can't prioritize getting that released this week. Thanks for the nudge.

@ylg ylg self-assigned this Sep 18, 2023
@AnadyaNair
Copy link
Author

I've checked the developer tools regarding the same, where I recognise that empty fields occur because of there seems to be no SVG generated for the micro bar-charts. Moreover, the console reads errors regarding getContext, in the screen.js.

Fields with SVG (working fine):

image

Fields without SVG (no micro bar-chart displayed):

image
image
image

@ylg
Copy link
Member

ylg commented Sep 20, 2023

@AnadyaNair All rendering is client-side, so when data is received, the client code will add HTML and/or SVG elements in as necessary. That is, "missing" SVG in the inspector is the result, not that cause.

@AnadyaNair
Copy link
Author

Noted. Impressive work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants