Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition to Flycheck #220

Open
tonini opened this issue Nov 19, 2014 · 7 comments
Open

Transition to Flycheck #220

tonini opened this issue Nov 19, 2014 · 7 comments

Comments

@tonini
Copy link
Collaborator

tonini commented Nov 19, 2014

I always just had problems with flymake and most of the time just haven't it enabled.

I think we should consider to switch to Flycheck.

Why?

Because it's just great. Language support is amazing, it's highly maintained and people just use it.

@senny @jone what do you guys think about that?

@senny
Copy link
Owner

senny commented Nov 19, 2014

can you prepare a PR for me to check out for a bit? I'm not a big fan of Flymake but it serves the purpose I use it for "ok". If Flycheck delivers the same I'm happy to move over.

@jone
Copy link
Collaborator

jone commented Nov 19, 2014

I've had trouble with flymake and compile-mode; flymake crashes sometimes silently while compiling.
If flycheck does the job and does not crash I'll happily switch 😉

@phgross
Copy link
Contributor

phgross commented Nov 19, 2014

I've had the same problems like @jone describe. So if flycheck would solve this troubles, that would be nice 👍

@tonini
Copy link
Collaborator Author

tonini commented Nov 24, 2014

@jone What's the default source code checker for python these days? Currently we're going with pyflakes and flymake. Maybe going with flake8 https://pypi.python.org/pypi/flake8 would be decent way.

What do you think?

@jone
Copy link
Collaborator

jone commented Nov 24, 2014

I'd go with pyflakes only.

flake8 includes pyflakes but also pep8.
pyflakes only checks for logical errors in the code, but pep8 also checks for the python style guide, which results in a lot more errors.
Although we (at my company) try to apply pep8 to a certain degree it is sometimes impossible and often hard to do so.

Personally I want see pyflakes while coding (as flymake does it with a red background) but I want pep8 errors only on demand (I have other setups for this). I think I would disable it if it would include pep8 because of the code I sometimes work on and because it would be too distracting for me..

@tonini
Copy link
Collaborator Author

tonini commented Nov 25, 2014

@jone So you think we should just setup flycheck with pyflakes and let the rest to the user itself to customize?

@jone
Copy link
Collaborator

jone commented Nov 25, 2014

Yes, that sounds good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants