Skip to content
This repository has been archived by the owner on May 6, 2021. It is now read-only.

Better error messages (or add logging) #71

Open
timiwahalahti opened this issue Mar 29, 2018 · 1 comment
Open

Better error messages (or add logging) #71

timiwahalahti opened this issue Mar 29, 2018 · 1 comment

Comments

@timiwahalahti
Copy link

It would be really helpful for developers if error message would contain more information when sending test email. Right now it only states that "Email wasn't sent." and that's really not helpful when trying to figure out the reason for it.

@leigh-ols
Copy link

+1

At present class-sendgrid-smtp.php catches exceptions and then simply returns false. Throwing away the error and failing to send the email. Relying on the calling plugin/code to recognise that the wp_mail() call failed, and handle the failure.

However the default on Linux is to use the standard Linux command which will queue a failed email and attempt to re-send it. As such most plugins are coded in a manner where they simply don't bother to check the success of the wp_mail() function.

If Sendgrid is to be a replacement for the default functionality, should handle this gracefully, preferably using the WordPress' cron functionality to retry failed emails at a later date but at the very least provide logs of failures.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants