Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization #26

Open
Naapperas opened this issue Aug 8, 2023 · 4 comments · May be fixed by #75
Open

Localization #26

Naapperas opened this issue Aug 8, 2023 · 4 comments · May be fixed by #75
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers P2 Low Priority

Comments

@Naapperas
Copy link
Contributor

We should provide the ability to have translations on the website. This allows for all the text to be centralized in one place and thus editing it is easier than searching everywhere where some text might be.

To use this we should exploit Laravel's built-in localization features

@Naapperas Naapperas added enhancement New feature or request good first issue Good for newcomers P2 Low Priority labels Aug 8, 2023
@ttoino
Copy link
Member

ttoino commented Sep 15, 2023

Maybe relevant, how jetstream used to do localization (this feature was dropped): laravel/jetstream@9dc5307

@ttoino
Copy link
Member

ttoino commented Sep 15, 2023

An interesting library for the frontend: https://github.com/rmariuzzo/Laravel-JS-Localization

@Naapperas
Copy link
Contributor Author

Maybe relevant, how jetstream used to do localization (this feature was dropped): laravel/jetstream@9dc5307

What is preventing us from using this approach?

@ttoino
Copy link
Member

ttoino commented Sep 15, 2023

Maybe relevant, how jetstream used to do localization (this feature was dropped): laravel/jetstream@9dc5307

What is preventing us from using this approach?

I think this would force us to define translations in the frontend and the backend separately. It's not necessarily bad, but it could lead to duplication or inconsistencies.

@Naapperas Naapperas self-assigned this Sep 17, 2023
@Naapperas Naapperas linked a pull request Sep 17, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers P2 Low Priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants