Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] making manual changes to the seedphrase, automatically generated by the KRUX camera #401

Closed
Garrysoon opened this issue Jun 7, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@Garrysoon
Copy link

very useful to add human entropy to seedphrase, automatically generated by KRUX camera.

@Garrysoon Garrysoon added the enhancement New feature or request label Jun 7, 2024
@tadeubas
Copy link
Contributor

tadeubas commented Jun 7, 2024

This will be possible with this issue: #384

@Garrysoon
Copy link
Author

Garrysoon commented Jun 7, 2024

This will be possible with this issue: #384

perhaps seedXOR allows this, but simply being able to make changes for ready-made seedphrase is much easier to implement.

@tadeubas
Copy link
Contributor

tadeubas commented Jun 7, 2024

Making changes to a non-verifiably generated mnemonic will not guarantee the verifiability of the process and the user will continue to trust Krux code. The only verifiable option would be to generate the mnemonic from dice and combine it with the unverifiable mnemonic generated by Krux via camera. Making changes to an unverifiable process will not make the process better.

@Garrysoon
Copy link
Author

Garrysoon commented Jun 7, 2024

Making changes to a non-verifiably generated mnemonic will not guarantee the verifiability of the process and the user will continue to trust Krux code. The only verifiable option would be to generate the mnemonic from dice and combine it with the unverifiable mnemonic generated by Krux via camera. Making changes to an unverifiable process will not make the process better.

In my opinion making changes to an unverifiable process will MAKE the process better...
At least I know that these are individual words generated by me + trust to the creator of original seed generator from a picture with good entropy = a partially verifiable process. Much better.
In addition, such human changes are available in anover generators.

  • plus, it can limit this possibility only for a part of the words, for example, up to 12 out of 24, and then even entering all 12 identical words will not make the seedphrase
    worse than just only 12 words.

@odudex
Copy link
Member

odudex commented Jun 8, 2024

Independently of adding this feature or not, with a little patience you can already can do it in Krux:

  1. Create entropy with camera.
  2. Note down the mnemonic words.
  3. Create new mnemonic from words
  4. Use the camera mnemonic as reference, change the words you want. New algorithm will allow only a valid checksum new last word.

Or similarly with tinyseed:
Export camera entropy as tinyseed
Go to load from tinyseed
Toggle some bits differently from the original.
Valid checksum will be calculated in real time.

@Garrysoon
Copy link
Author

Garrysoon commented Jun 9, 2024

Independently of adding this feature or not, with a little patience you can already can do it in Krux:

  1. Create entropy with camera.
  2. Note down the mnemonic words.
  3. Create new mnemonic from words
  4. Use the camera mnemonic as reference, change the words you want. New algorithm will allow only a valid checksum new last word.

Or similarly with tinyseed: Export camera entropy as tinyseed Go to load from tinyseed Toggle some bits differently from the original. Valid checksum will be calculated in real time.

This opportunity is wonderful. But we continue to strive for the perfection of the ideal, FAST Swiss knife. In any case, thanks to Odudex and the team.

@odudex
Copy link
Member

odudex commented Oct 11, 2024

Done in release 24.09.0

@odudex odudex closed this as completed Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants