pio_usb: mask endp with b'111 (d'7) #123
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not fix any issue, but makes a token packet creation
according to the usb 2.0 spec, where the third byte contains:
ENDP CRC5
3 5
so make `ENDP & 0x7` and not `ENDP & 0x1f`. This actually could
be a nasty bug, but the code a few lines above makes sure that
`dat` has exactly 11 bits, so actual incorrect mask does not
make any effect.
This patch makes mask according to the spec.
Signed-off-by: Roman Penyaev <[email protected]>
|
i think using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not fix any issue, but makes token packet creation according to the usb 2.0 spec, where the third byte contains:
so make
ENDP & 0x7and notENDP & 0x1f. This actually could be a nasty bug, but the code a few lines above makes sure thatdathas exactly 11 bits, so incorrect mask does not make any effect.This patch makes mask according to the spec.