Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "feat: limit EVM max gas refund to 150% of used gas" #37

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Revert "feat: limit EVM max gas refund to 150% of used gas" #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 13 additions & 21 deletions core/state_transition.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,39 +473,31 @@ func (st *StateTransition) TransitionDb() (*ExecutionResult, error) {
}

func (st *StateTransition) refundGas(refundQuotient uint64) uint64 {
// Calculate state change refund
stateRefund := st.gasUsed() / refundQuotient
if stateRefund > st.state.GetRefund() {
stateRefund = st.state.GetRefund()
// Apply refund counter, capped to a refund quotient
refund := st.gasUsed() / refundQuotient
if refund > st.state.GetRefund() {
refund = st.state.GetRefund()
}

// Calculate the total refund (unused gas + state refund)
totalRefund := st.gasRemaining + stateRefund

// Calculate the maximum refund allowed (150% of gas used)
maxRefund := st.gasUsed()/2 + st.gasUsed()

// Ensure the refund does not exceed the maximum allowed
if totalRefund > maxRefund {
totalRefund = maxRefund
if st.evm.Config.Tracer != nil && st.evm.Config.Tracer.OnGasChange != nil && refund > 0 {
st.evm.Config.Tracer.OnGasChange(st.gasRemaining, st.gasRemaining+refund, tracing.GasChangeTxRefunds)
}

// Update gasRemaining
st.gasRemaining += stateRefund
st.gasRemaining += refund

// Return ETH for total refund, exchanged at the original rate.
totalRefundValue := new(big.Int).Mul(new(big.Int).SetUint64(totalRefund), st.msg.GasPrice)
st.state.AddBalance(st.msg.From, totalRefundValue, tracing.BalanceIncreaseGasReturn)
// Return ETH for remaining gas, exchanged at the original rate.
remaining := new(big.Int).Mul(new(big.Int).SetUint64(st.gasRemaining), st.msg.GasPrice)
st.state.AddBalance(st.msg.From, remaining, tracing.BalanceIncreaseGasReturn)

// Notify the tracer about the gas change
if st.evm.Config.Tracer != nil && st.evm.Config.Tracer.OnGasChange != nil && st.gasRemaining > 0 {
st.evm.Config.Tracer.OnGasChange(st.gasRemaining, 0, tracing.GasChangeTxLeftOverReturned)
}

// Update gas pool
// Also return remaining gas to the block gas counter so it is
// available for the next transaction.
st.gp.AddGas(st.gasRemaining)

return stateRefund
return refund
}

// gasUsed returns the amount of gas used up by the state transition.
Expand Down
Loading