json: configurable numeric decoding #137
Merged
+334
−111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial benchmark results show this change to be approximately performance-neutral.
extemporalgenome
force-pushed
the
json-big-int
branch
6 times, most recently
from
126373b
to
8e09c7a
Compare
extemporalgenome
force-pushed
the
json-big-int
branch
from
8e09c7a
to
c9c213a
Compare
extemporalgenome
force-pushed
the
json-big-int
branch
from
dcc13ac
to
d5215a2
Compare
dzhagr
reviewed
Dec 1, 2023
.github/workflows/benchmark.yml
Outdated
| with: | ||
| name: ${{ matrix.ref }} | ||
| path: bench.txt | ||
| - name: Steup Go |
There was a problem hiding this comment.
Apparently it was already like that... I just changed the indentation. I'll fix
dzhagr
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This facilitates richer support for decoding JSON numbers into
any. Whereas before, the only options were float64 and json.Number (essentially a string),ParseacceptsUseInt64,UseUint64, andUseBigIntfor in-range integer values (whereUseBigIntsupports arbitrary integers).