Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add unknown option to current state #887

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Conversation

ashton-huxtable
Copy link
Contributor

  • Added a check for currentState to allow for the unknown value occasionally generated by RN per this GH issue in iOS. This will prevent the backgroundFlushPolicy from failing on initial launch.

@ashton-huxtable ashton-huxtable requested a review from oscb October 9, 2023 16:38
@ashton-huxtable
Copy link
Contributor Author

@oscb - code has been updated per your review

Copy link
Contributor

@oscb oscb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ashton!

@oscb oscb merged commit a0a3b0d into master Oct 18, 2023
4 checks passed
@oscb oscb deleted the background_policy_fix branch October 18, 2023 23:09
oscb pushed a commit that referenced this pull request Oct 20, 2023
## [@segment/analytics-react-native-v2.17.0](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-v2.16.1...@segment/analytics-react-native-v2.17.0) (2023-10-20)

### Features

* add consent management and support for onetrust cmp ([#882](#882)) ([375684f](375684f))

### Bug Fixes

* add unknown option to current state ([#887](#887)) ([a0a3b0d](a0a3b0d))
* change content type to json ([#885](#885)) ([e8ddeb4](e8ddeb4))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants