Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer dependency issue for Firebase plugin #880

Closed
jacquesdev opened this issue Sep 16, 2023 · 4 comments
Closed

Peer dependency issue for Firebase plugin #880

jacquesdev opened this issue Sep 16, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@jacquesdev
Copy link
Contributor

jacquesdev commented Sep 16, 2023

Summary

I've noticed that your firebase plugin you have the baked in peer dependencies:
"@react-native-firebase/app": "^17.3.2",
"@react-native-firebase/analytics": "^17.3.2"

Proposed Solution

Would it be possible to either not have that, or to upgrade to the 18? Technically it means, Firebase for my whole app is stuck at a level, which is around 6 months old, losing out on many of the improvements that have been made since then? I've just installed firebase 18.4.0, and segment is still happily sending events (at least there doesn't seem to be a dependency conflict). I've done that using --force, but it's a pain to have to that every time, especially if it's not really important

@jacquesdev jacquesdev added the enhancement New feature or request label Sep 16, 2023
@oscb
Copy link
Contributor

oscb commented Sep 19, 2023

We pin it to a major version since new releases might break up things. But given that there's no issue happy to give it a bump.

@jacquesdev
Copy link
Contributor Author

jacquesdev commented Sep 22, 2023

Thanks @oscb - would you like me to get in a PR for this? Are you ok with version 18.4.0 (current latest)?

@oscb
Copy link
Contributor

oscb commented Sep 25, 2023

@jacquesdev that would be very appreciated! latest sounds good.

@jacquesdev
Copy link
Contributor Author

Added: #883

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants