Added Horizontal Mentor card #197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you add a screenshot? Also the pipeline is failing @dilankavishka |
|
@anjula-sack, I did the changes |
anjula-sack
requested changes
Oct 26, 2024
Comment on lines
+141
to
+143
| <MentorCardHorizontal | ||
| mentor={mentee?.mentor}> | ||
| </MentorCardHorizontal> |
There was a problem hiding this comment.
Suggested change
| <MentorCardHorizontal | |
| mentor={mentee?.mentor}> | |
| </MentorCardHorizontal> | |
| <MentorCard mentor={mentee?.mentor} /> |
Comment on lines
+22
to
+27
| <a | ||
| href="#" | ||
| className="hover:underline" | ||
| target="_blank" | ||
| rel="noreferrer" | ||
| > |
| import ProfilePic from '../ProfilePic/index.tsx'; | ||
|
|
||
| interface MentorCardProps { | ||
| mentor: Mentor|undefined; |
There was a problem hiding this comment.
Suggested change
| mentor: Mentor|undefined; | |
| mentor?: Mentor; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this PR is to fix #105
Goals
This PR introduces a separate component for the mentor card in horizontal view, as opposed to keeping it inside the MentorProfile component. The goal is to improve reusability across the project and maintain cleaner code.
Approach
Screenshot
Checklist