Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] The fee field is not respected when using stx_signTransaction #197

Open
1 task done
vini-btc opened this issue Dec 11, 2024 · 1 comment
Open
1 task done

Comments

@vini-btc
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

SATS-CONNECT Version

3.0.1

Current Behavior

When using unsigned stx transfers, wallet opens a pop-up for the user to sign the transaction, but it doesn't respect the fee set by the developer.

Expected Behavior

Wallet would open the pop-up to sign a transaction with the fee set by the developer.

Steps To Reproduce

Create an unsigned token transfer transaction:

   const txOptions: UnsignedTokenTransferOptions = {
      network: Network,
      amount,
      recipient,
      fee,
      nonce,
      publicKey,
    };
    const serializedTx = serializeTransaction(
      await makeUnsignedSTXTokenTransfer(txOptions)
    );

    const signedTransaction = await xverseRequest("stx_signTransaction", {
      transaction: serializedTx,
      pubkey: publicKey,
    });

Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)

No response

Anything else?

Usign unsigned contract calls works as expected.

@m-aboelenein
Copy link
Member

Hi @vini-btc ,Thank you for bringing this to our attention. We are aware of the inconsistencies in the fee settings, where the wallet currently prompts the user to sign the transaction but does not honor the fee set by the developer. We currently updating the fee handling logic and will provide an update as soon as the fix is implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants