Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix #321: psi template, update curve_type to ecdh_curve #322

Closed
wants to merge 2 commits into from

Conversation

gxcuit
Copy link

@gxcuit gxcuit commented May 22, 2024

Hi there,

I noticed the latest psi, the attrs of curve has changed to ecdh_curve. However, the template in the cuscia did not change accordingly.

https://github.com/secretflow/secretpad/blob/1467a1bdb6f38a31aa81cf93425a4ac1850b48e3/config/components/secretflow.json#L286

gxcuit added 2 commits May 22, 2024 13:59
fix: change `curve_type` to `ecdh_curve`
fix change curve_type to ecdh_curve
Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@gxcuit gxcuit changed the title Bug fix: psi template, update curve_type to ecdh_curve Bug fix #321: psi template, update curve_type to ecdh_curve May 22, 2024
@gxcuit
Copy link
Author

gxcuit commented May 22, 2024

#321

@gxcuit
Copy link
Author

gxcuit commented May 22, 2024

I have read the CLA Document and I hereby sign the CLA

CLA Assistant Lite bot: Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

@UniqueMarvin
Copy link
Collaborator

Thank you for contributing the code. This PR is outdated, so I have closed it for now.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants