New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uniswap V2 bugs (WasmEdge Revert) #121

Open

eee4017 opened this issue Sep 23, 2021 · 0 comments

Assignees

Labels

bug

Contributor

eee4017 commented Sep 23, 2021 •

edited

Loading

Wasm section size too small
When copying deploy bytecode, WasmEdge will revert due to OOB
https://github.com/second-state/uniswap-v2-core/blob/vincent/upgrade_to_solc_0.8.6/contracts/yul/UniswapV2ERC20.yul#L18

This error could be solved by assigning larger memory secion to wasm-ld

wasm-ld --entry main --gc-sections --allow-undefined --export=__heap_base --max-memory=16777216 --initial-memory=16777216 UniswapV2ERC20.o -o UniswapV2ERC20.wasm

keccak256 failed
WasmEdge will revert due to OOB. I guess that this is a bug in keccak256 implementation.
https://github.com/second-state/uniswap-v2-core/blob/vincent/upgrade_to_solc_0.8.6/contracts/yul/UniswapV2ERC20.yul#L138

The behavior here is strange, since WasmEdge would not stop at the OOB occurs.

The text was updated successfully, but these errors were encountered:

eee4017 added the bug label

eee4017 self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment