Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't call close on already closed fd... #176

Open
giannitedesco opened this issue May 1, 2019 · 1 comment
Open

Shouldn't call close on already closed fd... #176

giannitedesco opened this issue May 1, 2019 · 1 comment

Comments

@giannitedesco
Copy link

If WatchManager.close() is called twice then bad things can happen :)
Also if WatchManager.close() is called then Notifier.stop() the same thing can happen.
Basically, there needs to be a well defined lifetime/ownership for the fd otherwise we can start randomly closing the fd's belonging to other objects which don't expect it.

@giannitedesco
Copy link
Author

Maybe context managers would be nice too, that'd make it clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant