Skip to content
This repository has been archived by the owner on Sep 1, 2020. It is now read-only.

Hoist chart data selectors #2

Open
jameshadfield opened this issue Apr 18, 2019 · 0 comments
Open

Hoist chart data selectors #2

jameshadfield opened this issue Apr 18, 2019 · 0 comments

Comments

@jameshadfield
Copy link
Member

jameshadfield commented Apr 18, 2019

Currently the data selectors provide transformed data directly to the chart components. When faceting this has the unfortunate side effect that each chart has a different scale, which is confusing. The easiest way out of this is hoisting the data selector calls (and modifying the selectors) and then passing the relevant data to each chart as props. This would allow a consistent scale to be provided, and facilitate potential UI improvements such as only displaying one scale / legend for multiple charts.

UPDATE:
Integrating the modeling results into the data flow makes the makeSelectDataForChart selector even more complex and may want to be looked at during this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant