Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context siteId Lost #21

Open
korgon opened this issue Jul 27, 2023 · 0 comments
Open

Context siteId Lost #21

korgon opened this issue Jul 27, 2023 · 0 comments
Labels
type: feature New functionality

Comments

@korgon
Copy link
Contributor

korgon commented Jul 27, 2023

When using the extension, we block the script that would normally contain the siteId found via getContext.

<script src="https://snapui.searchspring.io/xxxxxx/bundle.js" id="searchspring-context">
    // existing context variables
</script>

When the extension provided bundle is injected onto the page we currently have the option to merge any existing context variables that were found on the original script tag - we do not however grab the siteId.

This can cause some issues on websites that are not configured to set a siteId in the code, but rely fully on the siteId from the script src.

@korgon korgon added the type: feature New functionality label Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New functionality
Projects
None yet
Development

No branches or pull requests

1 participant