Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Product URL (?) #10

Open
bupp925 opened this issue Jun 8, 2018 · 0 comments
Open

Fix the Product URL (?) #10

bupp925 opened this issue Jun 8, 2018 · 0 comments

Comments

@bupp925
Copy link
Collaborator

bupp925 commented Jun 8, 2018

https://github.com/SearchSpring/magento2-searchspring-feed/blob/master/Helper/Generator.php#L188

I'm having a hard time understanding why the "url" field doesn't always work; in setups past, I've seen several of these URLs go to 404 pages. You'd know why that is better than I would, but seems like this "url" field should be updated to just reference domain.com/%url_key% instead? ... or something which always populated with a working URL.

For my understanding, this URL format can be configured differently for each store? Maybe there's a more reliable option than $product->getProductUrl()

Would be good if we could just use "url" as our Core Field, instead of remembering that a custom format is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant