Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'get terms from selection' rules #156

Merged
merged 1 commit into from
May 9, 2024

Conversation

ator-dev
Copy link
Member

@ator-dev ator-dev commented May 9, 2024

  • Improve splitting behaviour by only splitting on newlines, carriage returns, Unicode spaces, and Unicode "other" punctuation followed by spaces
    • If the selection contains any open/close bracket or initial/final quote punctuation, assume it is too complicated to sensibly split (for now) and skip the splitting phase
  • Use full Unicode category names in the regexps for maintainability

Fix #153

- Improve splitting behaviour by only splitting on newlines, carriage
  returns, Unicode spaces, and Unicode "other" punctuation *followed by*
  spaces
  - If the selection contains any open/close bracket or initial/final
    quote punctuation, assume it is too complicated to sensibly split
    (for now) and skip the splitting phase
- Use full Unicode category names in the regexps for maintainability
@ator-dev ator-dev merged commit 7647103 into searchmarkers:main May 9, 2024
@ator-dev ator-dev deleted the highlight-selection-alter branch May 9, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not separate words and reset default options?
1 participant