Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing fields for student suitability #31

Open
kasperjha opened this issue May 3, 2023 · 0 comments
Open

Confusing fields for student suitability #31

kasperjha opened this issue May 3, 2023 · 0 comments
Labels
enhancement New feature or request high-priority

Comments

@kasperjha
Copy link
Contributor

kasperjha commented May 3, 2023

There seems to be overlap between some fields in the student projects collection which may cause confusion.

Context

An entry in the student projects collection (_sprojects) has several fields related to who the project is suitable for. The is_group boolean represents whether this project is suitable for a group. Another field is types defines which thesis level this project is suitable for, and whether this project can be done as an internship.

To me these fields are confusing and the fields don't follow the single responsibility principle. For example the types field mixes information about thesis level with internships with values like MSc Int.. Also some values are derivatives of other like MSc Int. is for MSc.

Solutions

Some different solutions:

  • Consolidate into one suitable_for select field. It could for example take on the values: MSc, BSc, Group, Internship, Thesis and maybe even SPP for Short Programming Project.
  • Use more booleans. Create is_internship, is_thesis and is_SPP boolean fields, and keep the types field only for MSc and BSc.
  • Split into more select fields. For example education_level, team_size and industry_involvement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high-priority
Projects
None yet
Development

No branches or pull requests

2 participants