Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to apply against 13 ? #1

Closed
seandarcy opened this issue Oct 29, 2014 · 2 comments
Closed

how to apply against 13 ? #1

seandarcy opened this issue Oct 29, 2014 · 2 comments

Comments

@seandarcy
Copy link

  1. Since 13 has vp6 pass-through, no need to copy format_vp8.c, correct ??
  2. We still need to copy the opus codecs ??
  3. The patch fails for frame.c :

patch -p1 < ../opus/asterisk-opus-master/asterisk.patch
patching file build_tools/menuselect-deps.in
Hunk #1 succeeded at 41 (offset -1 lines).
patching file configure.ac
Hunk #1 succeeded at 448 (offset 20 lines).
Hunk #2 succeeded at 2212 (offset 44 lines).
patching file main/frame.c
Hunk #1 FAILED at 1029.
Hunk #2 FAILED at 1111.
2 out of 2 hunks FAILED -- saving rejects to file main/frame.c.rej
patching file makeopts.in
Hunk #1 succeeded at 273 (offset 1 line).

But do we need to patch frame.c ? Is the rest of the patch required ?

@seanbright
Copy link
Owner

The formats API changed significantly in Asterisk 13 and this patch hasn't been updated to take that into account.

I committed all of the autoconf stuff directly to the Asterisk 13 repository:

http://svnview.digium.com/svn/asterisk?view=revision&sortby=file&revision=426234

So the only thing that should be necessary is to updated codec_opus.c for the new formats API, and drop it in the codecs directory and build. I haven't done anything to convert it yet, so PRs are welcome.

@celevra celevra mentioned this issue Nov 17, 2014
@seanbright
Copy link
Owner

Opus support for Asterisk 13 has been implemented: de820fb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants