Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Summit sponsor - Apple #409

Merged
merged 5 commits into from
Oct 9, 2024
Merged

Summit sponsor - Apple #409

merged 5 commits into from
Oct 9, 2024

Conversation

bbrcknl
Copy link
Collaborator

@bbrcknl bbrcknl commented Oct 3, 2024

No description provided.

bbrcknl added 3 commits October 4, 2024 08:10
@bbrcknl
rebase over master
c4891ed 
Signed-off-by: Birgit Brecknell <[email protected]>
@bbrcknl
remove announcement
7e04f23 
Signed-off-by: Birgit Brecknell <[email protected]>
@bbrcknl
add apple logo and adjust spacing
8908115 
Signed-off-by: Birgit Brecknell <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Preview your changes here

The link checker found some issues!

Running 3 checks (Scripts, Links, Images) in ["_site"] on *.html files...


Checking 384 external links
Checking 605 internal links
Checking internal link hashes in 17 files
Ran on 61 files!


For the Links > External check, the following failures were found:

* At _site/Foundation/Summit/2024/index.html:395:

  External link https://www.linkedin.com/in/alison-felizzi-991244189 failed (status code 429)

* At _site/Foundation/Summit/2024/index.html:398:

  External link https://www.linkedin.com/in/alison-felizzi-991244189 failed (status code 429)

* At _site/Foundation/Summit/2024/index.html:465:

  External link https://www.linkedin.com/in/lucy-parker-13a484253/ failed (status code 429)

* At _site/Foundation/Summit/2024/index.html:469:

  External link https://www.linkedin.com/in/lucy-parker-13a484253/ failed (status code 429)

* At _site/Foundation/TSC/index.html:120:

  External link https://www.linkedin.com/in/mbrcknl failed (status code 429)

* At _site/Foundation/TSC/index.html:123:

  External link https://www.linkedin.com/in/mbrcknl failed (status code 429)

* At _site/news/2024.html:682:

  External link https://www.linkedin.com/in/alison-felizzi-991244189 failed (status code 429)

* At _site/news/2024.html:686:

  External link https://www.linkedin.com/in/alison-felizzi-991244189 failed (status code 429)

* At _site/news/2024.html:755:

  External link https://www.linkedin.com/in/lucy-parker-13a484253/ failed (status code 429)

* At _site/news/2024.html:759:

  External link https://www.linkedin.com/in/lucy-parker-13a484253/ failed (status code 429)

* At _site/news/index.html:681:

  External link https://www.linkedin.com/in/alison-felizzi-991244189 failed (status code 429)

* At _site/news/index.html:685:

  External link https://www.linkedin.com/in/alison-felizzi-991244189 failed (status code 429)

* At _site/news/index.html:754:

  External link https://www.linkedin.com/in/lucy-parker-13a484253/ failed (status code 429)

* At _site/news/index.html:758:

  External link https://www.linkedin.com/in/lucy-parker-13a484253/ failed (status code 429)


HTML-Proofer found 14 failures!
make: *** [Makefile:59: checklinks] Error 1

@bbrcknl bbrcknl marked this pull request as ready for review October 3, 2024 23:36
@bbrcknl
Copy link
Collaborator Author

bbrcknl commented Oct 3, 2024

@june-andronick Can you please review? There were some problems with linkedin links, but they should resolve themselves.

@bbrcknl bbrcknl requested a review from june-andronick October 3, 2024 23:37
june-andronick
june-andronick approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@june-andronick june-andronick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, thanks. Maybe just order them by alphabetical order? (but not that important)

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024

Preview your changes here

@bbrcknl
Copy link
Collaborator Author

bbrcknl commented Oct 9, 2024

Looks fine, thanks. Maybe just order them by alphabetical order? (but not that important)

Done!

Apple asked me to align the Apple and NIO logos. Also done.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024

Preview your changes here

@bbrcknl bbrcknl merged commit beaeab2 into master Oct 9, 2024
9 checks passed
@bbrcknl bbrcknl deleted the summit_sponsor_silver2 branch October 9, 2024 22:57
bbrcknl added a commit that referenced this pull request Oct 10, 2024
@bbrcknl
Summit sponsor - Apple (#409)
b2d96a1 
* add apple logo and adjust spacing
---------

Signed-off-by: Birgit Brecknell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@june-andronick june-andronick june-andronick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bbrcknl @june-andronick