Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolves #70
TL;DR; I added an XSD schema for validating the system XMLs. You are currently using numbers with underscores, such as
period="100_000"
which is not a valid XML number. I parse these as strings, which is fine as long as you trust your build tool to resolve these correctly.The long story
I asked ChatGPT to generate XSD schema from the few Microkit examples that are out there, and it did pretty well. I manually edited the XSD in a few places, and it certainly can be improved further, but IMHO it is good enough as it is. I recommend validating all
.system
files in a CI.