Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

results_parser: Use sorted lists instead of sets for column values #9

Open
2 tasks
gruberma opened this issue Feb 27, 2023 · 0 comments
Open
2 tasks
Labels
enhancement New feature or request

Comments

@gruberma
Copy link
Contributor

gruberma commented Feb 27, 2023

Following columns contain sets as values:

This is bad, because it makes the resulting CSV output non-deterministic, since the sets have non-deterministic order between different Python executions.
Originally it was used to filter out duplicate result entries (the same test is reported multiple times in the same run), which actually occurs in certain junit-xml files.

Solution: keep the duplicated-dropping set operation, but wrap it in sorted to convert it back to a list.

Watch out for the following also needed adjustments:

  • Adjust (and simplify) tests
    • now we can actually assert on string-equality of the output CSV files -> no parsing needed)
  • Adjust CSV parsing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant