Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add array api function to simplify adding arrays to modo #38

Open
2 tasks
almutlue opened this issue May 6, 2024 · 1 comment
Open
2 tasks

Add array api function to simplify adding arrays to modo #38

almutlue opened this issue May 6, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@almutlue
Copy link
Contributor

almutlue commented May 6, 2024

The current way of adding an array to a modo includes 2 steps:

  1. add the element specifying the array metadata to modo
  2. add the array to modos zarr group

For the user these steps can be confusing and we allow inconsistencies, e.g. specifying any array path in the element, unrelated where the array is added in the hierarchy. Also the zarr framework can feel cumbersome, if not used to.

  • Add modo api function modo.add_array() to wrap both steps
  • Update docs in docs/tutorials/modo_array()

Open question:

  1. What about modo.add_element()? Do we allow adding array metadata (step 1above)?
  2. Should modo_add_array() also take care of rowname/colname handling?
@almutlue
Copy link
Contributor Author

almutlue commented May 6, 2024

Proposal:

  • Input should be csv file or numpy array.
  • on api: add to add_element specific function for add_array, add_file
  • on cli: keep modo add (infer from datat type)

@cmdoret cmdoret added the enhancement New feature or request label Jun 6, 2024
@cmdoret cmdoret self-assigned this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants