Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Dedicated GitHub Actions for Improved Maintainability of Data Update Workflow #5

Open
kevinmatthes opened this issue Dec 4, 2022 · 1 comment

Comments

@kevinmatthes
Copy link
Contributor

I would like to suggest you the following GitHub Actions because I think that they would enhance both the readability and the maintainability of the GitHub Action workflow for the daily data update.

  • py-actions/[email protected]: install all Python software requirements listed in the requirements.txt located in the repository root; updates pip, wheel, and setuptools automatically, by default
  • fregante/[email protected]: setup up the GitHub Actions bot as authoring instance

Example:

# Line 34:
      - name: Install Python requirements
        if: steps.cache.outputs.cache-hit != 'true'
        uses: py-actions/[email protected]

# Line 48:
      - name: Configure GitHub Actions bot
        uses: fregante/[email protected]

      - name: Commit updated files
        run: git add -A && git commit -m 'Update data'

If you are interested, I can submit a Pull Request with the respective changes.

@kevinmatthes
Copy link
Contributor Author

There are further simplifications possible, for instance by applying one example from the checkout repository, https://github.com/actions/checkout/blob/ac593985615ec2ede58e132d2e21d2b1cbd6127c/README.md?plain=1#L215-L231.

The main idea is to update the checkout Action to v3 and to add a git push in line 54 in order to replace the succeeding step. This is also a security benefit as ad-m/[email protected] still uses the deprecated version 12 of Node.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant