Better accessibility #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdegueldre
reviewed
Mar 14, 2021
| @@ -39,7 +39,7 @@ const RoomSelector = ({socket, joinRoom}) => { | |||
| <h1>Public rooms</h1> | |||
| <p>(click to join)</p> | |||
| <div className="room-list"> | |||
| {rooms.map(room => <div key={room.id} onClick={room.id !== currentRoomId ? (() => { | |||
| {rooms.map((room, i) => <div key={room.id} tabIndex={i + 1} onClick={room.id !== currentRoomId ? (() => { | |||
There was a problem hiding this comment.
any reason to not just use tabIndex=0 ?
There was a problem hiding this comment.
With tabindex=0 you have to press Shift Tab, not just Tab. And you will be traversing list starting from last room. Because page starts with input field autofocus..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes first two points of #11
[update] Also added tabindex to rooms list