diff --git a/test/topology_custom/suite.yaml b/test/topology_custom/suite.yaml index 76e57a8a5fca..fe5a5e3acd70 100644 --- a/test/topology_custom/suite.yaml +++ b/test/topology_custom/suite.yaml @@ -5,18 +5,29 @@ cluster: extra_scylla_config_options: authenticator: AllowAllAuthenticator authorizer: AllowAllAuthorizer + enable_user_defined_functions: False + enable_tablets: True run_first: - test_raft_recovery_stuck - test_raft_recovery_basic - test_group0_schema_versioning - test_tablets_migration - test_zero_token_nodes_topology_ops + - test_raft_cluster_features + - test_raft_ignore_nodes + - test_tablets + - test_tablets2 +skip_in_release: + - test_raft_cluster_features skip_in_debug: - test_shutdown_hang - test_replace - test_old_ip_notification_repro - test_node_shutdown_waits_for_pending_requests + - test_cdc_generation_clearing + - test_cdc_generation_publishing run_in_dev: + - test_raft_ignore_nodes - test_group0_schema_versioning - test_different_group0_ids - test_replace_ignore_nodes diff --git a/test/topology_experimental_raft/test_alternator.py b/test/topology_custom/test_alternator.py similarity index 100% rename from test/topology_experimental_raft/test_alternator.py rename to test/topology_custom/test_alternator.py diff --git a/test/topology_experimental_raft/test_blocked_bootstrap.py b/test/topology_custom/test_blocked_bootstrap.py similarity index 100% rename from test/topology_experimental_raft/test_blocked_bootstrap.py rename to test/topology_custom/test_blocked_bootstrap.py diff --git a/test/topology_custom/test_boot_after_ip_change.py b/test/topology_custom/test_boot_after_ip_change.py index 713d61fb883c..182450fe8c0a 100644 --- a/test/topology_custom/test_boot_after_ip_change.py +++ b/test/topology_custom/test_boot_after_ip_change.py @@ -22,7 +22,8 @@ async def test_boot_after_ip_change(manager: ManagerClient) -> None: Regression test for #14468. Does not apply to Raft-topology mode. """ cfg = {'enable_user_defined_functions': False, - 'force_gossip_topology_changes': True} + 'force_gossip_topology_changes': True, + 'enable_tablets': False} logger.info(f"Booting initial cluster") servers = [await manager.server_add(config=cfg) for _ in range(2)] await wait_for_token_ring_and_group0_consistency(manager, time.time() + 30) diff --git a/test/topology_experimental_raft/test_cdc_generation_clearing.py b/test/topology_custom/test_cdc_generation_clearing.py similarity index 100% rename from test/topology_experimental_raft/test_cdc_generation_clearing.py rename to test/topology_custom/test_cdc_generation_clearing.py diff --git a/test/topology_experimental_raft/test_cdc_generation_data.py b/test/topology_custom/test_cdc_generation_data.py similarity index 100% rename from test/topology_experimental_raft/test_cdc_generation_data.py rename to test/topology_custom/test_cdc_generation_data.py diff --git a/test/topology_experimental_raft/test_cdc_generation_publishing.py b/test/topology_custom/test_cdc_generation_publishing.py similarity index 100% rename from test/topology_experimental_raft/test_cdc_generation_publishing.py rename to test/topology_custom/test_cdc_generation_publishing.py diff --git a/test/topology_experimental_raft/test_crash_coordinator_before_streaming.py b/test/topology_custom/test_crash_coordinator_before_streaming.py similarity index 100% rename from test/topology_experimental_raft/test_crash_coordinator_before_streaming.py rename to test/topology_custom/test_crash_coordinator_before_streaming.py diff --git a/test/topology_custom/test_different_group0_ids.py b/test/topology_custom/test_different_group0_ids.py index 9ba514b65d44..bebfb75ee04f 100644 --- a/test/topology_custom/test_different_group0_ids.py +++ b/test/topology_custom/test_different_group0_ids.py @@ -28,8 +28,9 @@ async def test_different_group0_ids(manager: ManagerClient): """ # Consistent topology changes are disabled to use repair based node operations. - scylla_a = await manager.server_add(config={'force_gossip_topology_changes': True}) - scylla_b = await manager.server_add(start=False, config={'force_gossip_topology_changes': True}) + cfg = {'force_gossip_topology_changes': True, 'enable_tablets': False} + scylla_a = await manager.server_add(config = cfg) + scylla_b = await manager.server_add(start=False, config = cfg) await manager.server_start(scylla_b.server_id, seeds=[scylla_b.ip_addr]) await manager.server_stop(scylla_b.server_id) diff --git a/test/topology_experimental_raft/test_fencing.py b/test/topology_custom/test_fencing.py similarity index 100% rename from test/topology_experimental_raft/test_fencing.py rename to test/topology_custom/test_fencing.py diff --git a/test/topology_custom/test_gossip_boot.py b/test/topology_custom/test_gossip_boot.py index 954bbe5f05c3..47fb90612e10 100644 --- a/test/topology_custom/test_gossip_boot.py +++ b/test/topology_custom/test_gossip_boot.py @@ -12,7 +12,8 @@ async def test_gossip_boot(manager: ManagerClient): """ cfg = {'error_injections_at_startup': ['gossiper_replicate_sleep'], - 'force_gossip_topology_changes': True} + 'force_gossip_topology_changes': True, + 'enable_tablets': False} servers = [await manager.server_add(config=cfg, timeout=60) for _ in range(3)] logs = [await manager.server_open_log(s.server_id) for s in servers] diff --git a/test/topology_custom/test_mv_admission_control.py b/test/topology_custom/test_mv_admission_control.py index 32eecf9e98e6..af569fbf283d 100644 --- a/test/topology_custom/test_mv_admission_control.py +++ b/test/topology_custom/test_mv_admission_control.py @@ -12,7 +12,7 @@ from test.topology.conftest import skip_mode from test.pylib.util import wait_for_view -from test.topology_experimental_raft.test_mv_tablets import pin_the_only_tablet, get_tablet_replicas +from test.topology_custom.test_mv_tablets import pin_the_only_tablet, get_tablet_replicas from cassandra.cluster import ConsistencyLevel, EXEC_PROFILE_DEFAULT # type: ignore from cassandra.cqltypes import Int32Type # type: ignore diff --git a/test/topology_custom/test_mv_backlog.py b/test/topology_custom/test_mv_backlog.py index c3a5e2e0ce10..13339f1d76e2 100644 --- a/test/topology_custom/test_mv_backlog.py +++ b/test/topology_custom/test_mv_backlog.py @@ -11,7 +11,7 @@ import pytest from test.topology.conftest import skip_mode from test.pylib.util import wait_for_view, wait_for -from test.topology_experimental_raft.test_mv_tablets import pin_the_only_tablet +from test.topology_custom.test_mv_tablets import pin_the_only_tablet from test.pylib.tablets import get_tablet_replica logger = logging.getLogger(__name__) diff --git a/test/topology_experimental_raft/test_mv_tablets.py b/test/topology_custom/test_mv_tablets.py similarity index 100% rename from test/topology_experimental_raft/test_mv_tablets.py rename to test/topology_custom/test_mv_tablets.py diff --git a/test/topology_experimental_raft/test_mv_tablets_replace.py b/test/topology_custom/test_mv_tablets_replace.py similarity index 98% rename from test/topology_experimental_raft/test_mv_tablets_replace.py rename to test/topology_custom/test_mv_tablets_replace.py index c6bdd8128a44..a29e5e5657ff 100644 --- a/test/topology_experimental_raft/test_mv_tablets_replace.py +++ b/test/topology_custom/test_mv_tablets_replace.py @@ -18,7 +18,7 @@ from test.topology.conftest import skip_mode from test.topology.util import get_topology_coordinator, find_server_by_host_id -from test.topology_experimental_raft.test_mv_tablets import get_tablet_replicas +from test.topology_custom.test_mv_tablets import get_tablet_replicas logger = logging.getLogger(__name__) diff --git a/test/topology_experimental_raft/test_node_isolation.py b/test/topology_custom/test_node_isolation.py similarity index 100% rename from test/topology_experimental_raft/test_node_isolation.py rename to test/topology_custom/test_node_isolation.py diff --git a/test/topology_experimental_raft/test_not_enough_token_owners.py b/test/topology_custom/test_not_enough_token_owners.py similarity index 100% rename from test/topology_experimental_raft/test_not_enough_token_owners.py rename to test/topology_custom/test_not_enough_token_owners.py diff --git a/test/topology_experimental_raft/test_raft_cluster_features.py b/test/topology_custom/test_raft_cluster_features.py similarity index 100% rename from test/topology_experimental_raft/test_raft_cluster_features.py rename to test/topology_custom/test_raft_cluster_features.py diff --git a/test/topology_experimental_raft/test_raft_ignore_nodes.py b/test/topology_custom/test_raft_ignore_nodes.py similarity index 100% rename from test/topology_experimental_raft/test_raft_ignore_nodes.py rename to test/topology_custom/test_raft_ignore_nodes.py diff --git a/test/topology_custom/test_read_repair.py b/test/topology_custom/test_read_repair.py index fe2f5abddc9a..46c9d2499512 100644 --- a/test/topology_custom/test_read_repair.py +++ b/test/topology_custom/test_read_repair.py @@ -222,7 +222,7 @@ async def test_incremental_read_repair(data_class, workdir, manager): host1, host2 = await wait_for_cql_and_get_hosts(cql, [node1, node2], time.time() + 30) - cql.execute("CREATE KEYSPACE ks WITH replication = {'class': 'NetworkTopologyStrategy', 'replication_factor': 2}") + cql.execute("CREATE KEYSPACE ks WITH replication = {'class': 'NetworkTopologyStrategy', 'replication_factor': 2} AND tablets = { 'enabled': false }") table_schema = f"CREATE TABLE ks.tbl ({data_class.column_spec}) WITH speculative_retry = 'NONE'" cql.execute(table_schema) diff --git a/test/topology_custom/test_replace_ignore_nodes.py b/test/topology_custom/test_replace_ignore_nodes.py index c336bdb29cd4..2f9b2a036fd9 100644 --- a/test/topology_custom/test_replace_ignore_nodes.py +++ b/test/topology_custom/test_replace_ignore_nodes.py @@ -26,7 +26,8 @@ async def test_replace_ignore_nodes(manager: ManagerClient) -> None: Preferably run it only in one mode e.g. dev. """ cfg = {'enable_user_defined_functions': False, - 'force_gossip_topology_changes': True} + 'force_gossip_topology_changes': True, + 'enable_tablets': False} logger.info(f"Booting initial cluster") servers = [await manager.server_add(config=cfg) for _ in range(7)] s2_id = await manager.get_host_id(servers[2].server_id) diff --git a/test/topology_experimental_raft/test_restart_cluster.py b/test/topology_custom/test_restart_cluster.py similarity index 100% rename from test/topology_experimental_raft/test_restart_cluster.py rename to test/topology_custom/test_restart_cluster.py diff --git a/test/topology_custom/test_table_drop.py b/test/topology_custom/test_table_drop.py index 31fcb880c97d..1869a29c449a 100644 --- a/test/topology_custom/test_table_drop.py +++ b/test/topology_custom/test_table_drop.py @@ -7,5 +7,6 @@ async def test_drop_table_during_streaming_receiver_side(manager: ManagerClient) 'error_injections_at_startup': ['stream_mutation_fragments_table_dropped'], 'enable_repair_based_node_ops': False, 'enable_user_defined_functions': False, - 'force_gossip_topology_changes': True + 'force_gossip_topology_changes': True, + 'enable_tablets': False }) for _ in range(2)] diff --git a/test/topology_experimental_raft/test_tablet_repair_scheduler.py b/test/topology_custom/test_tablet_repair_scheduler.py similarity index 100% rename from test/topology_experimental_raft/test_tablet_repair_scheduler.py rename to test/topology_custom/test_tablet_repair_scheduler.py diff --git a/test/topology_experimental_raft/test_tablets.py b/test/topology_custom/test_tablets2.py similarity index 100% rename from test/topology_experimental_raft/test_tablets.py rename to test/topology_custom/test_tablets2.py diff --git a/test/topology_experimental_raft/test_tablets_intranode.py b/test/topology_custom/test_tablets_intranode.py similarity index 100% rename from test/topology_experimental_raft/test_tablets_intranode.py rename to test/topology_custom/test_tablets_intranode.py diff --git a/test/topology_experimental_raft/test_tablets_merge.py b/test/topology_custom/test_tablets_merge.py similarity index 100% rename from test/topology_experimental_raft/test_tablets_merge.py rename to test/topology_custom/test_tablets_merge.py diff --git a/test/topology_experimental_raft/test_tablets_removenode.py b/test/topology_custom/test_tablets_removenode.py similarity index 100% rename from test/topology_experimental_raft/test_tablets_removenode.py rename to test/topology_custom/test_tablets_removenode.py diff --git a/test/topology_experimental_raft/test_tombstone_gc.py b/test/topology_custom/test_tombstone_gc.py similarity index 100% rename from test/topology_experimental_raft/test_tombstone_gc.py rename to test/topology_custom/test_tombstone_gc.py diff --git a/test/topology_experimental_raft/test_topology_ops.py b/test/topology_custom/test_topology_ops.py similarity index 100% rename from test/topology_experimental_raft/test_topology_ops.py rename to test/topology_custom/test_topology_ops.py diff --git a/test/topology_experimental_raft/test_topology_recovery_basic.py b/test/topology_custom/test_topology_recovery_basic.py similarity index 100% rename from test/topology_experimental_raft/test_topology_recovery_basic.py rename to test/topology_custom/test_topology_recovery_basic.py diff --git a/test/topology_experimental_raft/test_topology_recovery_majority_loss.py b/test/topology_custom/test_topology_recovery_majority_loss.py similarity index 100% rename from test/topology_experimental_raft/test_topology_recovery_majority_loss.py rename to test/topology_custom/test_topology_recovery_majority_loss.py diff --git a/test/topology_custom/test_topology_remove_garbage_group0.py b/test/topology_custom/test_topology_remove_garbage_group0.py index 8dac8d78e977..25b619853fb8 100644 --- a/test/topology_custom/test_topology_remove_garbage_group0.py +++ b/test/topology_custom/test_topology_remove_garbage_group0.py @@ -27,7 +27,8 @@ async def test_remove_garbage_group0_members(manager: ManagerClient): """ # 4 servers, one dead cfg = {'enable_user_defined_functions': False, - 'force_gossip_topology_changes': True} + 'force_gossip_topology_changes': True, + 'enable_tablets': False} servers = [await manager.server_add(config=cfg) for _ in range(4)] # Make sure that the driver has connected to all nodes, and they see each other as NORMAL diff --git a/test/topology_experimental_raft/test_topology_upgrade.py b/test/topology_custom/test_topology_upgrade.py similarity index 100% rename from test/topology_experimental_raft/test_topology_upgrade.py rename to test/topology_custom/test_topology_upgrade.py diff --git a/test/topology_experimental_raft/test_topology_upgrade_not_stuck_after_recent_removal.py b/test/topology_custom/test_topology_upgrade_not_stuck_after_recent_removal.py similarity index 100% rename from test/topology_experimental_raft/test_topology_upgrade_not_stuck_after_recent_removal.py rename to test/topology_custom/test_topology_upgrade_not_stuck_after_recent_removal.py diff --git a/test/topology_experimental_raft/test_zero_token_nodes_multidc.py b/test/topology_custom/test_zero_token_nodes_multidc.py similarity index 100% rename from test/topology_experimental_raft/test_zero_token_nodes_multidc.py rename to test/topology_custom/test_zero_token_nodes_multidc.py diff --git a/test/topology_experimental_raft/test_zero_token_nodes_no_replication.py b/test/topology_custom/test_zero_token_nodes_no_replication.py similarity index 100% rename from test/topology_experimental_raft/test_zero_token_nodes_no_replication.py rename to test/topology_custom/test_zero_token_nodes_no_replication.py diff --git a/test/topology_custom/test_zero_token_nodes_topology_ops.py b/test/topology_custom/test_zero_token_nodes_topology_ops.py index 68622de13665..2338a2d3152b 100644 --- a/test/topology_custom/test_zero_token_nodes_topology_ops.py +++ b/test/topology_custom/test_zero_token_nodes_topology_ops.py @@ -25,7 +25,9 @@ async def test_zero_token_nodes_topology_ops(manager: ManagerClient, tablets_ena - client requests to normal nodes in the presence of zero-token nodes (2 normal nodes, RF=2, CL=2) succeed """ logging.info('Trying to add a zero-token server in the gossip-based topology') - await manager.server_add(config={'join_ring': False, 'force_gossip_topology_changes': True}, + await manager.server_add(config={'join_ring': False, + 'force_gossip_topology_changes': True, + 'enable_tablets': False}, expected_error='the raft-based topology is disabled') normal_cfg = {'enable_tablets': tablets_enabled} diff --git a/test/topology_experimental_raft/__init__.py b/test/topology_experimental_raft/__init__.py deleted file mode 100644 index e69de29bb2d1..000000000000 diff --git a/test/topology_experimental_raft/conftest.py b/test/topology_experimental_raft/conftest.py deleted file mode 100644 index 374b0244b2e7..000000000000 --- a/test/topology_experimental_raft/conftest.py +++ /dev/null @@ -1,9 +0,0 @@ -# -# Copyright (C) 2023-present ScyllaDB -# -# SPDX-License-Identifier: LicenseRef-ScyllaDB-Source-Available-1.0 -# -# This file configures pytest for all tests in this directory, and also -# defines common test fixtures for all of them to use - -from test.topology.conftest import * diff --git a/test/topology_experimental_raft/suite.yaml b/test/topology_experimental_raft/suite.yaml deleted file mode 100644 index d637c9ea3430..000000000000 --- a/test/topology_experimental_raft/suite.yaml +++ /dev/null @@ -1,20 +0,0 @@ -type: Topology -pool_size: 4 -cluster: - initial_size: 0 -extra_scylla_config_options: - authenticator: AllowAllAuthenticator - authorizer: AllowAllAuthorizer - enable_user_defined_functions: False - enable_tablets: True -run_first: - - test_raft_cluster_features - - test_raft_ignore_nodes - - test_tablets -skip_in_release: - - test_raft_cluster_features -skip_in_debug: - - test_cdc_generation_clearing - - test_cdc_generation_publishing -run_in_dev: - - test_raft_ignore_nodes