Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error: redundant explicit link target on cargo_docs CI job #847

Closed
nsipplswezey opened this issue Oct 19, 2023 · 1 comment · Fixed by #848
Closed

error: redundant explicit link target on cargo_docs CI job #847

nsipplswezey opened this issue Oct 19, 2023 · 1 comment · Fixed by #848

Comments

@nsipplswezey
Copy link
Contributor

After syncing with latest changes on main branch CI fails on my fork on cargo_docs with linting errors:

https://github.com/nsipplswezey/scylla-rust-driver/actions/runs/6567434306/job/17840129362

error: redundant explicit link target
  --> scylla/src/lib.rs:16:55
   |
16 | //! All driver activity revolves around the [Session](crate::Session)\
   |                                              -------  ^^^^^^^^^^^^^^ explicit target is redundant
   |                                              |
   |                                              because label contains path that resolves to same destination
   |
   = note: when a link's destination is not specified,
           the label is used to resolve intra-doc links
   = note: `-D rustdoc::redundant-explicit-links` implied by `-D warnings`
help: remove explicit link target
   |
16 | //! All driver activity revolves around the [Session]\
   |                                             ~~~~~~~~~

Some research highlighted that this linting was added in 1.73
rust-lang/rust#113167
rust-lang/rust#87799

Confirmed same linting errors on my local up-to-date main branch as well.

nsipplswezey added a commit to nsipplswezey/scylla-rust-driver that referenced this issue Oct 19, 2023
error: redundant explicit link target
  --> scylla/src/lib.rs:16:55
   |
16 | //! All driver activity revolves around the [Session](crate::Session)\
   |                                              -------  ^^^^^^^^^^^^^^ explicit target is redundant
   |                                              |
   |                                              because label contains path that resolves to same destination
   |
   = note: when a link's destination is not specified,
           the label is used to resolve intra-doc links
   = note: `-D rustdoc::redundant-explicit-links` implied by `-D warnings`
help: remove explicit link target

fixes: scylladb#847
@nsipplswezey
Copy link
Contributor Author

Cleaned up here. #848
Now passes doc build on my fork CI https://github.com/nsipplswezey/scylla-rust-driver/actions/runs/6567644432/job/17840726403

Lorak-mmk pushed a commit to Lorak-mmk/scylla-rust-driver that referenced this issue Dec 21, 2023
error: redundant explicit link target
  --> scylla/src/lib.rs:16:55
   |
16 | //! All driver activity revolves around the [Session](crate::Session)\
   |                                              -------  ^^^^^^^^^^^^^^ explicit target is redundant
   |                                              |
   |                                              because label contains path that resolves to same destination
   |
   = note: when a link's destination is not specified,
           the label is used to resolve intra-doc links
   = note: `-D rustdoc::redundant-explicit-links` implied by `-D warnings`
help: remove explicit link target

fixes: scylladb#847
Lorak-mmk pushed a commit that referenced this issue Dec 21, 2023
error: redundant explicit link target
  --> scylla/src/lib.rs:16:55
   |
16 | //! All driver activity revolves around the [Session](crate::Session)\
   |                                              -------  ^^^^^^^^^^^^^^ explicit target is redundant
   |                                              |
   |                                              because label contains path that resolves to same destination
   |
   = note: when a link's destination is not specified,
           the label is used to resolve intra-doc links
   = note: `-D rustdoc::redundant-explicit-links` implied by `-D warnings`
help: remove explicit link target

fixes: #847
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant