Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the partition key's representation in tokio tracing to a human-readable form #720

Closed
piodul opened this issue May 10, 2023 · 0 comments · Fixed by #766
Closed

Change the partition key's representation in tokio tracing to a human-readable form #720

piodul opened this issue May 10, 2023 · 0 comments · Fixed by #766
Assignees

Comments

@piodul
Copy link
Collaborator

piodul commented May 10, 2023

Currently, in RequestSpan, we are including a "routing key" - which is the partition key serialized in a particular way. The driver computes it in order to apply MurmurHash3 on it and compute the token, but it is technically also possible for users to decode a partition key from it. However, while this was simple to implement, this form is hard to parse manually and one needs to know the types of partition key's columns.

This information is available to the driver at the moment when the routing key is included in tracing, so for the sake users' convenience, the driver should decode it itself. In most of the cases it can be done without any allocations (especially after #462).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant