Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi node tests in CI #307

Closed
cvybhu opened this issue Sep 30, 2021 · 3 comments
Closed

Multi node tests in CI #307

cvybhu opened this issue Sep 30, 2021 · 3 comments

Comments

@cvybhu
Copy link
Contributor

cvybhu commented Sep 30, 2021

We should add some tests that use a cluster of multiple nodes.
For example:

  • Make a cluster of 3 scylla nodes
  • Make one node unreachable from the driver (drop all packets from driver to this node)
  • run cargo test

This would prevent bugs like: #306

It looks like java-driver uses ccm to run tests in their CI, we could do something similar.
https://github.com/scylladb/java-driver/blob/scylla-3.x/.github/workflows/tests.yml#L26

@Jasperav
Copy link
Contributor

is ccm required? I guess a simple docker compose file, mention in #306, would also work. When a node is added to the cluster while this driver is running in an application, does this driver adds the new node in memory? Maybe that can be tested as well while fixing this issue

@piodul
Copy link
Collaborator

piodul commented Sep 22, 2022

In #489, we modified the CI to run tests on a 3-node cluster. We can additionally consider tests which will modify the cluster while they are running to tests how the driver behaves when the topology changes.

@wprzytula wprzytula added this to the 1.1.0 milestone Jul 28, 2023
@Lorak-mmk Lorak-mmk self-assigned this Nov 15, 2023
@Lorak-mmk Lorak-mmk removed their assignment Jul 31, 2024
@Lorak-mmk
Copy link
Collaborator

Closing in favor of #1097

@roydahan roydahan removed this from the 1.x.0 milestone Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants