Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type discrepancy between QueryRowsResult::column_specs and PreparedStatement::get_result_set_col_specs #1132

Open
muzarski opened this issue Nov 26, 2024 · 0 comments
Open

Type discrepancy between QueryRowsResult::column_specs and PreparedStatement::get_result_set_col_specs #1132

muzarski opened this issue Nov 26, 2024 · 0 comments
Assignees
@wprzytula
Labels
API-breaking This might introduce incompatible API changes API-stability Part of the effort to stabilize the API
Milestone
0.16.0

Comments

@muzarski
Copy link
Contributor

The former returns ColumnSpecs<'_>, while the latter returns &[ColumnSpec<'_>].

In a sense, returned values represent the same thing - thus, the returned types should be the same or easily convertible into one another (currently ColumnSpecs constructor is pub(crate)).
@muzarski muzarski mentioned this issue Nov 26, 2024
Merged
3 tasks
@muzarski muzarski added API-breaking This might introduce incompatible API changes API-stability Part of the effort to stabilize the API labels Nov 26, 2024
@muzarski muzarski added this to the 0.16.0 milestone Nov 26, 2024
@wprzytula wprzytula assigned wprzytula and unassigned muzarski Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wprzytula wprzytula

Labels
API-breaking This might introduce incompatible API changes API-stability Part of the effort to stabilize the API
Projects
None yet
Milestone
0.16.0
Development

No branches or pull requests
2 participants
@wprzytula @muzarski