From 290b2085ec2ee6e260c36ac921af6cf7c1fa0f5e Mon Sep 17 00:00:00 2001
From: muzarski <mikolaj.uzarski@scylladb.com>
Date: Tue, 13 Feb 2024 08:15:11 +0100
Subject: [PATCH] docs: adjust auth docs to box futures

The trait definitions using async_trait before have changed, and so
the docs needed to be adjusted.

The trait implementations in examples now return boxed futures as well.
---
 docs/source/connecting/authentication.md | 52 +++++++++++++-----------
 1 file changed, 29 insertions(+), 23 deletions(-)

diff --git a/docs/source/connecting/authentication.md b/docs/source/connecting/authentication.md
index 8b60cfecfd..9c6ed0e086 100644
--- a/docs/source/connecting/authentication.md
+++ b/docs/source/connecting/authentication.md
@@ -32,49 +32,55 @@ Finally, to make use of the custom authentication, use the `authenticator_provid
 # extern crate scylla_cql;
 # extern crate tokio;
 # extern crate bytes;
-# extern crate async_trait;
+# extern crate futures;
 # use std::error::Error;
 # use std::sync::Arc;
 use bytes::{BufMut, BytesMut};
-use async_trait::async_trait;
+use futures::{future::BoxFuture, FutureExt};
 use scylla::authentication::{AuthError, AuthenticatorProvider, AuthenticatorSession};
 
 struct CustomAuthenticator;
 
-#[async_trait]
 impl AuthenticatorSession for CustomAuthenticator {
     // to handle an authentication challenge initiated by the server.
     // The information contained in the token parameter is authentication protocol specific.
     // It may be NULL or empty. 
-    async fn evaluate_challenge(
-        &mut self,
-        _token: Option<&[u8]>,
-    ) -> Result<Option<Vec<u8>>, AuthError> {
-        Err("Challenges are not expected".to_string())
+    fn evaluate_challenge<'a>(
+        &'a mut self,
+        token: Option<&'a [u8]>,
+    ) -> BoxFuture<'_, Result<Option<Vec<u8>>, AuthError>> {
+        async move { Err("Challenges are not expected".to_string()) }.boxed()
     }
 
     // to handle the success phase of exchange. The token parameters contain information that may be used to finalize the request.
-    async fn success(&mut self, _token: Option<&[u8]>) -> Result<(), AuthError> {
-        Ok(())
+    fn success<'a>(
+        &'a mut self,
+        token: Option<&'a [u8]>
+    ) -> BoxFuture<'_, Result<(), AuthError>> {
+        async move { Ok(()) }.boxed()
     }
 }
 
 struct CustomAuthenticatorProvider;
 
-#[async_trait]
 impl AuthenticatorProvider for CustomAuthenticatorProvider {
-    async fn start_authentication_session(
-        &self,
-        _name: &str,
-    ) -> Result<(Option<Vec<u8>>, Box<dyn AuthenticatorSession>), AuthError> {
-        let mut response = BytesMut::new();
-        let cred = "\0cassandra\0cassandra";
-        let cred_length = 20;
-
-        response.put_i32(cred_length);
-        response.put_slice(cred.as_bytes());
-
-        Ok((Some(response.to_vec()), Box::new(CustomAuthenticator)))
+    fn start_authentication_session<'a>(
+        &'a self,
+        authenticator_name: &'a str,
+    ) -> BoxFuture<'_, Result<(Option<Vec<u8>>, Box<dyn AuthenticatorSession>), AuthError>> {
+        async move {
+            let mut response = BytesMut::new();
+            let cred = "\0cassandra\0cassandra";
+            let cred_length = 20;
+
+            response.put_i32(cred_length);
+            response.put_slice(cred.as_bytes());
+
+            Ok((
+                Some(response.to_vec()),
+                Box::new(CustomAuthenticator) as Box<dyn AuthenticatorSession>
+            ))
+        }.boxed()
     }
 }