Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Move overriding Scylla Operator's log level to CI scripts and make it configurable #2297

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[WIP] Move overriding Scylla Operator's log level to CI scripts and make it configurable #2297

wants to merge 2 commits into from
+95 −38

Conversation

rzetelskik
Copy link
Member

Description of your changes: wip

Which issue is resolved by this Pull Request:
Resolves #2296

/cc

@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

@rzetelskik: GitHub didn't allow me to request PR reviews from the following users: rzetelskik.

Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Description of your changes: wip

Which issue is resolved by this Pull Request:
Resolves #2296

/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@scylla-operator-bot scylla-operator-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 3, 2025
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rzetelskik
Once this PR has been reviewed and has the lgtm label, please assign zimnx for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rzetelskik rzetelskik force-pushed the operator-loglevel-ci-script branch from 674ff94 to 4570486 Compare January 8, 2025 11:59
@scylla-operator-bot scylla-operator-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 8, 2025
@rzetelskik rzetelskik force-pushed the operator-loglevel-ci-script branch 4 times, most recently from 6e104a8 to 7e42f88 Compare January 8, 2025 13:26
@scylla-operator-bot scylla-operator-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 8, 2025
@rzetelskik rzetelskik changed the title [WIP] Move overriding Operator's and Manager's log level to CI scripts and make it configurable [WIP] Move overriding Scylla Operator's and Scylla Manager controller's log level to CI scripts and make it configurable Jan 8, 2025
@rzetelskik rzetelskik changed the title [WIP] Move overriding Scylla Operator's and Scylla Manager controller's log level to CI scripts and make it configurable [WIP] Move overriding Scylla Operator's log level to CI scripts and make it configurable Jan 8, 2025
@rzetelskik rzetelskik force-pushed the operator-loglevel-ci-script branch 2 times, most recently from 4f970b5 to 67740d8 Compare January 8, 2025 15:10
@rzetelskik
Copy link
Member Author

Proof that loglevel propagated in ci-deploy.sh:

@rzetelskik rzetelskik force-pushed the operator-loglevel-ci-script branch 4 times, most recently from fdf5ffa to 2ac104d Compare January 8, 2025 16:04
@rzetelskik rzetelskik force-pushed the operator-loglevel-ci-script branch from 2ac104d to 76ad542 Compare January 8, 2025 16:16
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

@rzetelskik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-parallel 76ad542 link true /test e2e-gke-parallel

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

E2E scripts cause unnecessary rolling restart of the operator by patching log level
1 participant
@rzetelskik