Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 6.2] fix(nemesis): ignore networkd coredumps during BlockNetwork nemesis #9528

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Dec 10, 2024

The change adds reducing of coredump event severity during disrupt_network_block disruption, if coredump was triggered by an error in networkd service of
version 255 or lower (the root cause is decribed in #9135).

Fixes: #9135

Testing

❯ grep 'CoreDumpEvent Severity' -rn -A1 sct-runner-events-8e69a961
sct-runner-events-8e69a961/events.log:728:2024-12-10 09:10:06.374: (CoreDumpEvent Severity.WARNING) period_type=one-time event_id=a53eda06-9288-4679-ba76-61781b5cd728 during_nemesis=NetworkBlock node=Node longevity-5gb-1h-BlockNetworkMonkey-db-node-8e69a961-1 [63.33.152.9 | 10.4.20.40]
sct-runner-events-8e69a961/events.log-729-executable=/usr/lib/systemd/systemd-networkd executable_version=255.4
--

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

(cherry picked from commit bc96c1c)

Parent PR: #9485

@mergify mergify bot added the conflicts label Dec 10, 2024
Copy link
Author

mergify bot commented Dec 10, 2024

Cherry-pick of bc96c1c has failed:

On branch mergify/bp/branch-6.2/pr-9485
Your branch is up to date with 'origin/branch-6.2'.

You are currently cherry-picking commit bc96c1c2d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   sdcm/coredump.py
	modified:   sdcm/sct_events/system.py
	modified:   unit_tests/test_data/test_coredump/filebased/fail_upload_test_remoter.json
	modified:   unit_tests/test_data/test_coredump/filebased/fail_upload_test_results.json
	modified:   unit_tests/test_data/test_coredump/filebased/success_test_remoter.json
	modified:   unit_tests/test_data/test_coredump/filebased/success_test_results.json
	modified:   unit_tests/test_data/test_coredump/systemd/exceptions_limit_not_reached_test_remoter.json
	modified:   unit_tests/test_data/test_coredump/systemd/exceptions_limit_not_reached_test_results.json
	modified:   unit_tests/test_data/test_coredump/systemd/fail_upload_test_remoter.json
	modified:   unit_tests/test_data/test_coredump/systemd/fail_upload_test_results.json
	modified:   unit_tests/test_data/test_coredump/systemd/success_test_remoter.json
	modified:   unit_tests/test_data/test_coredump/systemd/success_test_results.json
	modified:   unit_tests/test_data/test_coredump/systemd/success_test_systemd_248_remoter.json
	modified:   unit_tests/test_data/test_coredump/systemd/success_test_systemd_248_results.json

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   sdcm/nemesis.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot assigned dimakr Dec 10, 2024
@mergify mergify bot marked this pull request as draft December 10, 2024 19:15
The change adds reducing of coredump event severity during disrupt_network_block
disruption, if coredump was triggered by an error in networkd service of
version 255 or lower (the root cause is decribed in #9135).

Fixes: #9135
(cherry picked from commit bc96c1c)
@dimakr dimakr force-pushed the mergify/bp/branch-6.2/pr-9485 branch from 21d6fd5 to 519d498 Compare December 11, 2024 13:52
@dimakr dimakr removed the conflicts label Dec 11, 2024
@dimakr dimakr marked this pull request as ready for review December 11, 2024 14:12
@dimakr
Copy link
Contributor

dimakr commented Dec 11, 2024

Resolved the conflict.

@fruch fruch merged commit ceb87b6 into branch-6.2 Dec 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants