-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roadmap #54
Comments
All sounds good with me. Should we also start to be more disciplined about version number bumps with merges to the main branch? Maybe there's automation for that too...? |
Good point. How about we release a version 0.1.0 once support for X, obs, var, obs_names, var_names and layers is implemented and unit tested for the HDF5AnnData, InMemoryAnnData, SeuratConverter and SingleCellExperimented? From that point on, we add additional functionality by merging PRs into the main branch and adding changelog entries to CHANGELOG.md. In my opinion we shouldn't merge #50 until the current classes are feature complete. @lazappi @mtmorgan WDYT? |
I'll mention https://github.com/neurogenomics/scKirby which I recently became aware of @bschilder. A very cursory look indicates that it could definitely leverage anndataR (it currently uses anndata) when it matures. It also contains 'innovations' like reticulate & basilisk conda-based environments for structured control of Python dependencies. |
* update docs * move class diagram to vignette * remove doc folder to #54 * don't include design doc in built package
The roadmap is now documented in milestones and vignettes, so closing this issue. |
Proposed interface
Class diagram
Notation:
X: Matrix
- variableX
is of typeMatrix
*X: Matrix
- variableX
is abstractto_SingleCellExperiment(): SingleCellExperiment
- functionto_SingleCellExperiment
returns object of typeSingleCellExperiment
*to_SingleCellExperiment()
- functionto_SingleCellExperiment
is abstractOO-framework
S4, RC, or R6?
Choosing an OOP system depends on the project requirements, developer familiarity, and desired balance between formality, performance, and ease of use.
Approach
AbstractAnnData
,HDF5AnnData
,InMemoryAnnData
X
,layers
,obs
,var
for nowread_h5ad()
,$write_h5ad()
$to_SingleCellExperiment()
Optional:
$to_Seurat()
ZarrAnnData
ReticulateAnnData
Challenges - Previously encountered issues
Below are previously encountered issues when reading h5ad files using hdf5r. They could be
to create test cases.
uns
No test data yet:
Roadmap
Should we create a public road map / can I add the following items to the project board?
Before release 0.1.0:
from_SingleCellExperiment
#59)from_Seurat
andto_Seurat
#60)Parallel to current release cycle:
After release 0.1.0:
The text was updated successfully, but these errors were encountered: